Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop GC and SServers first when stopping cluster #5396

Merged
merged 3 commits into from
Mar 12, 2025

Conversation

dlmarion
Copy link
Contributor

The GC and Scan Server processes can put a load onto the metadata table with scan and writes. This activity could hold up metadata tablet unloading. These processes aren't necessary for an orderly shutdown, so they can be shut down first.

The GC and Scan Server processes can put a load onto the
metadata table with scan and writes. This activity could
hold up metadata tablet unloading. These processes aren't
necessary for an orderly shutdown, so they can be shut
down first.
@dlmarion dlmarion added this to the 2.1.4 milestone Mar 11, 2025
@dlmarion dlmarion self-assigned this Mar 11, 2025
Copy link
Contributor

@keith-turner keith-turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Was this manually tested?

Copy link
Contributor

@ddanielr ddanielr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Fluo-uno, confirmed that scan servers and garbage collector are stopped before everything else when accumulo-cluster stop is called.

@dlmarion
Copy link
Contributor Author

Tested with Fluo-uno, confirmed that scan servers and garbage collector are stopped before everything else when accumulo-cluster stop is called.

Thanks for testing, I had to run out to an appointment.

@ddanielr ddanielr merged commit 4e0c998 into apache:2.1 Mar 12, 2025
8 checks passed
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late review, but LGTM

@dlmarion dlmarion deleted the stop-all-gc-sserver-first branch March 12, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants