-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop GC and SServers first when stopping cluster #5396
Conversation
The GC and Scan Server processes can put a load onto the metadata table with scan and writes. This activity could hold up metadata tablet unloading. These processes aren't necessary for an orderly shutdown, so they can be shut down first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. Was this manually tested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with Fluo-uno, confirmed that scan servers and garbage collector are stopped before everything else when accumulo-cluster stop
is called.
Thanks for testing, I had to run out to an appointment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Late review, but LGTM
The GC and Scan Server processes can put a load onto the metadata table with scan and writes. This activity could hold up metadata tablet unloading. These processes aren't necessary for an orderly shutdown, so they can be shut down first.