Fix WebViewsIT #5388
Merged
Fix WebViewsIT #5388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-turner
approved these changes
Mar 7, 2025
| // Using the mocks we can verify that the getModel method gets called via debugger | ||
| // however it's difficult to continue to mock through the jersey MVC code for the properly built | ||
| // response. | ||
| // Our silly HashMapWriter registered in the configure method gets wired in and used here. | ||
| Response output = target("tables/foo").request().get(); | ||
| assertEquals(200, output.getStatus(), "should return status 200"); | ||
| String responseBody = output.readEntity(String.class); | ||
| assertTrue(responseBody.contains("tableID=foo") && responseBody.contains("table=bar")); | ||
| assertTrue(responseBody.contains("tableId=foo") && responseBody.contains("table=bar")); |
There was a problem hiding this comment.
could a constant be used for tableId?
There was a problem hiding this comment.
Yea I was thinking about this too. It seems like a good improvement. It would probably be helpful and make the code safer but would be a lot more changes. I'll merge this PR to get the test passing in the build and then create a follow on to add constants for all of the parameters in this category.
There was a problem hiding this comment.
Created #5394 to track this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5351 the URL parameter to request a page for a specific table changed from
tableIDtotableId. This PR updates the IT to the correct expected paramtableId.I also took this opportunity to make one var final in the test and remove an exception that wasn't being thrown.