fixes AES decryption threading issue #5384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A single Cipher object was shared between multiple inputstreams when decrypting AES data. This caused decryption to fail when mutliple threads created input streams for decryption. This could potentially cause failure for a single thread also if it interleaves reading from multiple streams that use the same Cipher. Modified the code to create a Cipher per input stream.
ivakegg
approved these changes
Mar 7, 2025
I do not think compactions would ever have multiple threads writing. WAL writes may have multiple threads writing, not sure need to investigate. I tried to create multithreaded unit test for the write case and was having problems getting that test working so did not change the write code. Will open a follow on issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A single Cipher object was shared between multiple inputstreams when decrypting AES data. This caused decryption to fail when mutliple threads created input streams for decryption. This could potentially cause failure for a single thread also if it interleaves reading from multiple streams that use the same Cipher.
Modified the code to create a Cipher per input stream.