Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for multiple dead compactions #5380

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test for multiple dead compactions #5380

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f66bc9
test for multiple dead compactions
ArbaazKhan1 Mar 5, 2025
3e5669f
simplified test
ArbaazKhan1 Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 55 additions & 12 deletions ...nager/src/test/java/org/apache/accumulo/manager/compaction/CompactionCoordinatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,15 @@ protected void cancelCompactionOnCompactor(String address, String externalCompac

}

private TExternalCompaction createMockCompaction() {
TExternalCompaction mockCompaction = EasyMock.createMock(TExternalCompaction.class);
expect(mockCompaction.getJob()).andReturn(new TExternalCompactionJob()).anyTimes();
expect(mockCompaction.getCompactor()).andReturn("localhost:9133").anyTimes();
expect(mockCompaction.getGroupName()).andReturn(Constants.DEFAULT_RESOURCE_GROUP_NAME)
.anyTimes();
return mockCompaction;
}

@Test
public void testCoordinatorColdStart() throws Exception {

Expand Down Expand Up @@ -416,18 +425,9 @@ public void testCleanUpRunning() throws Exception {
expect(manager.getSteadyTime()).andReturn(SteadyTime.from(100000, TimeUnit.NANOSECONDS))
.anyTimes();

TExternalCompaction ext1 = EasyMock.createMock(TExternalCompaction.class);
expect(ext1.getJob()).andReturn(new TExternalCompactionJob()).anyTimes();
expect(ext1.getCompactor()).andReturn("localhost:9133").anyTimes();
expect(ext1.getGroupName()).andReturn(Constants.DEFAULT_RESOURCE_GROUP_NAME).anyTimes();
TExternalCompaction ext2 = EasyMock.createMock(TExternalCompaction.class);
expect(ext2.getJob()).andReturn(new TExternalCompactionJob()).anyTimes();
expect(ext2.getCompactor()).andReturn("localhost:9133").anyTimes();
expect(ext2.getGroupName()).andReturn(Constants.DEFAULT_RESOURCE_GROUP_NAME).anyTimes();
TExternalCompaction ext3 = EasyMock.createMock(TExternalCompaction.class);
expect(ext3.getJob()).andReturn(new TExternalCompactionJob()).anyTimes();
expect(ext3.getCompactor()).andReturn("localhost:9133").anyTimes();
expect(ext3.getGroupName()).andReturn(Constants.DEFAULT_RESOURCE_GROUP_NAME).anyTimes();
TExternalCompaction ext1 = createMockCompaction();
TExternalCompaction ext2 = createMockCompaction();
TExternalCompaction ext3 = createMockCompaction();

EasyMock.replay(context, creds, security, manager, ext1, ext2, ext3);

Expand Down Expand Up @@ -455,4 +455,47 @@ public void testCleanUpRunning() throws Exception {
EasyMock.verify(context, creds, security, manager, ext1, ext2, ext3);

}

@Test
public void testCleanUpMultipleDeadCompactions() throws Exception {

ServerContext context = EasyMock.createNiceMock(ServerContext.class);
expect(context.getCaches()).andReturn(Caches.getInstance()).anyTimes();
expect(context.getConfiguration()).andReturn(DefaultConfiguration.getInstance()).anyTimes();

TCredentials creds = EasyMock.createNiceMock(TCredentials.class);
AuditedSecurityOperation security = EasyMock.createNiceMock(AuditedSecurityOperation.class);
Manager manager = EasyMock.createNiceMock(Manager.class);
expect(manager.getSteadyTime()).andReturn(SteadyTime.from(100000, TimeUnit.NANOSECONDS))
.anyTimes();

ExternalCompactionId ecid1 = ExternalCompactionId.generate(UUID.randomUUID());
ExternalCompactionId ecid2 = ExternalCompactionId.generate(UUID.randomUUID());
ExternalCompactionId ecid3 = ExternalCompactionId.generate(UUID.randomUUID());

TExternalCompaction deadCompaction1 = createMockCompaction();
TExternalCompaction deadCompaction2 = createMockCompaction();
TExternalCompaction deadCompaction3 = createMockCompaction();

EasyMock.replay(context, creds, security, manager, deadCompaction1, deadCompaction2,
deadCompaction3);

TestCoordinator coordinator =
new TestCoordinator(context, security, new ArrayList<>(), manager);

coordinator.getRunning().put(ecid1, new RunningCompaction(deadCompaction1));
coordinator.getRunning().put(ecid2, new RunningCompaction(deadCompaction2));
coordinator.getRunning().put(ecid3, new RunningCompaction(deadCompaction3));

assertEquals(Set.of(ecid1, ecid2, ecid3), coordinator.getRunning().keySet());

coordinator.setMetadataCompactionIds(Set.of(ecid1));
coordinator.cleanUpInternalState();

assertEquals(Set.of(ecid1), coordinator.getRunning().keySet());

EasyMock.verify(context, creds, security, manager, deadCompaction1, deadCompaction2,
deadCompaction3);
}

}