Add deepCopy to VisibilityFilter #5373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctubbsii
reviewed
Mar 5, 2025
core/src/main/java/org/apache/accumulo/core/iterators/user/VisibilityFilter.java
Outdated
Show resolved
Hide resolved
|
@loganasherjones were you proposing to fix this for the main branch only, or for an earlier version, like 2.1? |
Co-authored-by: Christopher Tubbs <ctubbsii@apache.org>
|
I suppose it should be fixed as far back as feasible; should I base my changes off a different branch? |
|
@loganasherjones - I think it depends on whether you need the fix in a specific version. This seems simple enough that it could be put into the next 2.1 patch release in which case you would rebase onto the 2.1 branch. |
|
Yeah I see no reason not to backport it. I'll rebase it later tonight. |
|
Closing this PR in favor of #5385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
deepCopymethod to the userVisibilityFilteriterator.This is a demonstration of how to solve #5372.