Removes a constructor from SimpleLoadBalancer #5363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the single TableId constructor from SimpleLoadBalancer and modifies the balancer logic to use the tablesToBalance method from the balancerParams.
|
Seeing an issue with the TableLoadBalancerTest. Needs more investigation. |
keith-turner
reviewed
Mar 1, 2025
core/src/main/java/org/apache/accumulo/core/spi/balancer/SimpleLoadBalancer.java
Show resolved
Hide resolved
SimpleLoadBalancer did not have a multi-table balance test for a subset of tables. Added a test for balancing two of three total tables
|
Reviewed this code with @keith-turner and realized that removing this constructor actually breaks all user created table balancers that are supposed to be loaded by the TableLoadBalancer. TableLoadBalancer requires user defined balancers to have a constructor that accepts a tableId, but we do not enforce that behavior with any interface in the SPI. Leaving this open to make javadoc updates. But these changes will need to be done in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the single TableId constructor from SimpleLoadBalancer and modifies the balancer logic to use the tablesToBalance method from the balancerParams.
This ensures that the SimpleLoadBalancer will only balance on a subset of tables vs balancing all tables.