Created LoadFilesTest #5355
Merged
Created LoadFilesTest #5355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddanielr
reviewed
Feb 24, 2025
server/manager/src/test/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFilesTest.java
Outdated
Show resolved
Hide resolved
ddanielr
approved these changes
Feb 24, 2025
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFiles.java
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFiles.java
Outdated
Show resolved
Hide resolved
Comment on lines
+111
to
+114
| assertEquals(3, tablets.size()); | ||
| assertEquals(tm.get(0), tablets.get(0)); | ||
| assertEquals(tm.get(1), tablets.get(1)); | ||
| assertEquals(tm.get(2), tablets.get(2)); |
There was a problem hiding this comment.
Could use subList to shorten this check
Suggested change
| assertEquals(3, tablets.size()); | |
| assertEquals(tm.get(0), tablets.get(0)); | |
| assertEquals(tm.get(1), tablets.get(1)); | |
| assertEquals(tm.get(2), tablets.get(2)); | |
| assertEquals(tm.subList(0,3), tablets); |
There was a problem hiding this comment.
While this is less lines of code, it's not as easy to identify where the issue is on a test failure.
Comment on lines
+118
to
+121
| assertEquals(3, tablets.size()); | ||
| assertEquals(tm.get(tm.size() - 3), tablets.get(tablets.size() - 3)); | ||
| assertEquals(tm.get(tm.size() - 2), tablets.get(tablets.size() - 2)); | ||
| assertEquals(tm.get(tm.size() - 1), tablets.get(tablets.size() - 1)); |
There was a problem hiding this comment.
Could also use subList here
Suggested change
| assertEquals(3, tablets.size()); | |
| assertEquals(tm.get(tm.size() - 3), tablets.get(tablets.size() - 3)); | |
| assertEquals(tm.get(tm.size() - 2), tablets.get(tablets.size() - 2)); | |
| assertEquals(tm.get(tm.size() - 1), tablets.get(tablets.size() - 1)); | |
| assertEquals(tm.subList(tm.size()-3, tm.size()), tablets); |
server/manager/src/test/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFilesTest.java
Outdated
Show resolved
Hide resolved
server/manager/src/test/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFilesTest.java
Outdated
Show resolved
Hide resolved
server/manager/src/test/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFilesTest.java
Outdated
Show resolved
Hide resolved
server/manager/src/test/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFilesTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
+189
to
+194
| assertEquals(5, extents.size()); | ||
| assertTrue(extents.contains(nke(null, "a"))); | ||
| assertTrue(extents.contains(nke("a", "b"))); | ||
| assertTrue(extents.contains(nke("b", "c"))); | ||
| assertTrue(extents.contains(nke("l", "m"))); | ||
| assertTrue(extents.contains(nke("m", "n"))); |
There was a problem hiding this comment.
Could shorten using Set.of
Suggested change
| assertEquals(5, extents.size()); | |
| assertTrue(extents.contains(nke(null, "a"))); | |
| assertTrue(extents.contains(nke("a", "b"))); | |
| assertTrue(extents.contains(nke("b", "c"))); | |
| assertTrue(extents.contains(nke("l", "m"))); | |
| assertTrue(extents.contains(nke("m", "n"))); | |
| assertEquals(Set.of(nke(null, "a"), nke("a", "b"), nke("b", "c"),nke("l", "m"),nke("m", "n")), extents); |
There was a problem hiding this comment.
While this is less lines of code, it's not as easy to identify where the issue is on a test failure.
| loadRanges.put(nke("l", "n"), "f1 f2 f4 f5"); | ||
| loadRanges.put(nke("n", "r"), "f2 f4"); | ||
| loadRanges.put(nke("r", "w"), "f2 f5"); | ||
| loadRanges.put(nke("w", null), "f2 f6"); |
There was a problem hiding this comment.
This load mapping covers all data in the table w/ no gaps. Need to test that case. Additionally it would be nice to test other load mappings w/ gaps and not starting ending at -inf or +inf.
There was a problem hiding this comment.
In b217cfe I added another test that uses non-contiguous ranges on a subset of the tables tablets.
dlmarion
added a commit
to dlmarion/accumulo
that referenced
this pull request
Feb 27, 2025
When merging apache#5355 to main the FILES column ended up not being fetched for the tablet metadata because the Loader.pauseLimit variable had not been set. This variable was set in the call to Loader.start, which happens after the TabletsMetadata is configured
dlmarion
added a commit
that referenced
this pull request
Feb 27, 2025
When merging #5355 to main the FILES column ended up not being fetched for the tablet metadata because the Loader.pauseLimit variable had not been set. This variable was set in the call to Loader.start, which happens after the TabletsMetadata is configured
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.