added validate method into TabletMetadata #5340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlmarion
reviewed
Feb 19, 2025
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletMetadata.java
Outdated
Show resolved
Hide resolved
dlmarion
reviewed
Feb 19, 2025
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletMetadata.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletMetadata.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletMetadata.java
Outdated
Show resolved
Hide resolved
| @@ -558,6 +559,26 @@ private static Optional<TServerInstance> checkServer(ClientContext context, Stri | |||
| .map(address -> new TServerInstance(address, stat.getEphemeralOwner())); | |||
| } | |||
|
|
|||
| public static void validate(TabletMetadata tm) { | |||
| if (!tm.fetchedCols.contains(ColumnType.FILES) || !tm.sawPrevEndRow) { | |||
There was a problem hiding this comment.
If we fetched files, may not see any files for a tablet can avoid some work by checking if the set is empty. The sawPrevEndRow is more for error checking. If we fetched the PREV_ROW then its always expeced that it will be seen, so can check if it was fetched. Other code will throw an error if prev row was fetched and not seen.
Suggested change
| if (!tm.fetchedCols.contains(ColumnType.FILES) || !tm.sawPrevEndRow) { | |
| if (files.isEmpty() || !tm.fetchedCols.contains(ColumnType.PREV_ROW)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes issue #5242
Created a Validate method inside Tablet Metadata to check overlap of files and tablet ranges.