Fix Fate pool watcher bug #5171
Conversation
Was incorrectly calculating the number of TransactionRunners to execute
There was a problem hiding this comment.
LGTM, I'm not sure how doable it is but looking at this I'm wondering if it would be possible to write a test that verifies the correct number of transaction runners are started if the pool is resized. That could always be done as a follow on or maybe just added as part of #5130 as that will be refactoring all the thread pool stuff anyways
Yeah, I considered that as well. I think it would be a doable test. I think most likely I'll be adding tests for all the changes for #5130 anyways so would probably be easiest to include with those changes (would have the downside of only testing in 4.0+ though). Or, could just add the test here or as a follow on later like you mentioned |
|
I'll just merge this now since I am already merging something else from 2.1 through main. I'll make myself a note about the test |
Was incorrectly calculating the number of TransactionRunners to execute.
getQueue().size()is the number of tasks that have been submitted to the pool that currently don't have a thread available to work on them. This should instead be the number of tasks that are currently running. Before this was submitting new TransactionRunners unnecessarilyNoticed when working on #5130