Update parent POM to 30 and remove contrib dir #3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `contrib/` directory: * Force use of JDK 17 for building aggregate javadocs for website, to avoid needing to patch buggy JDK 11 javadocs before publishing * Relocate contrib/ci scripts to more Maven-like location, src/build/ci * Remove redundant copy of contrib/accumulo-logo.png; use identical copy from monitor module for the README.md * Remove unmaintained contrib/scripts/check-tservers.py (has not received any substantive updates since initial publication, and does not work with current versions of Python, and is not documented (if updated, this can be restored to a blog on the website, or added elsewhere as a maintenance tool, but there are probably better ways of checking a cluster's health using non-python command-line utilities) * Relocate license template and formatter config file to src/build, and fix license-header.txt references using build-helper's rootlocation rather than session.executionRootDirectory Bump ASF parent POM to version 30 and related POM improvements: * Remove useless comment about `<url>`, regarding plugin not built in this repo * Ensure `maven.site.skip` is true, since we don't use that to build our website, and don't want that plugin running at all, and remove the outdated and unused src/site/site.xml site descriptor * Stop overriding plugin versions that are the same as in the parent POM (or in the case of maven-site-plugin, doesn't matter because we don't use that plugin) * Remove extraneous maven-clean-plugin configuration that isn't needed since those files don't appear in our source tree and are cleaned up already from the target directory * Bump minimum Maven version to build, because apilyzer requires 3.6 * Adopt version property naming convention ASF parent POM Other fixes: * Bump some build plugins * Bump errorprone and fix newly detected illogical check if int is greater than `Integer.MAX_VALUE` * Bump some dependency versions
EdColeman
approved these changes
Jun 28, 2023
dlmarion
reviewed
Jun 28, 2023
server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java
Show resolved
Hide resolved
|
Full ITs passed. |
asfgit
pushed a commit
that referenced
this pull request
Aug 14, 2023
Remove `contrib/` directory: * Force use of JDK 17 for building aggregate javadocs for website, to avoid needing to patch buggy JDK 11 javadocs before publishing * Relocate contrib/ci scripts to more Maven-like location, src/build/ci * Remove redundant copy of contrib/accumulo-logo.png; use identical copy from monitor module for the README.md * Remove unmaintained contrib/scripts/check-tservers.py (has not received any substantive updates since initial publication, and does not work with current versions of Python, and is not documented (if updated, this can be restored to a blog on the website, or added elsewhere as a maintenance tool, but there are probably better ways of checking a cluster's health using non-python command-line utilities) * Relocate license template and formatter config file to src/build, and fix license-header.txt references using build-helper's rootlocation rather than session.executionRootDirectory Bump ASF parent POM to version 30 and related POM improvements: * Remove useless comment about `<url>`, regarding plugin not built in this repo * Ensure `maven.site.skip` is true, since we don't use that to build our website, and don't want that plugin running at all, and remove the outdated and unused src/site/site.xml site descriptor * Stop overriding plugin versions that are the same as in the parent POM (or in the case of maven-site-plugin, doesn't matter because we don't use that plugin) * Remove extraneous maven-clean-plugin configuration that isn't needed since those files don't appear in our source tree and are cleaned up already from the target directory * Bump minimum Maven version to build, because apilyzer requires 3.6 * Adopt version property naming convention ASF parent POM Other fixes: * Bump some build plugins * Bump errorprone and fix newly detected illogical check if int is greater than `Integer.MAX_VALUE` * Bump some dependency versions
|
Applied to 2.1.2 as 9e8b59c in prep for 2.1.2-rc1, as this includes a lot of build quality fixes and a few CVE fixes in our dependencies. |
|
Looks like this finds an issue in one of the tests, so the |
Yep, already fixed in #3691, a few hours before this comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
contrib/directory:Bump ASF parent POM to version 30 and related POM improvements:
<url>, regarding plugin not built in this repomaven.site.skipis true, since we don't use that to build our website, and don't want that plugin running at all, and remove the outdated and unused src/site/site.xml site descriptorOther fixes:
Integer.MAX_VALUE