CLI - loader v3 to v4 migration #4856
Open
+324
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
LucasSte
reviewed
Feb 7, 2025
runtime/src/bank/tests.rs
Outdated
| @@ -13381,6 +13381,180 @@ fn test_deploy_last_epoch_slot() { | |||
| assert_eq!(result_with_feature_enabled, Ok(())); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_loader_v3_to_v4_migration() { | |||
| @@ -4255,6 +4418,46 @@ mod tests { | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_cli_parse_migrate_program() { | |||
There was a problem hiding this comment.
This is the CLI. Error handling here is only for slightly nicer error messages. The actual security comes from what we test in test_loader_v3_to_v4_migration.
|
|
Lichtso
force-pushed
the
cli/loader_v3_to_v4_migration
branch
from
7d0f4d0 to
8889a6c
Compare
Lichtso
force-pushed
the
cli/loader_v3_to_v4_migration
branch
from
8889a6c to
70b55b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Split off from #4661 as requested (#4661 (review)).
Summary of Changes
Adds a CLI subcommand for migrating loader-v3 programs to loader-v4.