Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the text and the login container is overlapping with each other (#589) #768

Merged
merged 1 commit into from
May 23, 2024
Merged

fixed the text and the login container is overlapping with each other (#589) #768

merged 1 commit into from
May 23, 2024

Conversation

Ayushmaanagarwal1211
Copy link
Contributor

Description

I fixed the text is overlapping with login page in light mode and the css is not showing to be correct so i replace height:100vh with height : 100% .

Fixes: #589

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have made this from my own
  • I have taken help from some online resourses
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

before
Screenshot 2024-05-23 160015

After
Screenshot 2024-05-23 160030

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swapreads ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 10:31am

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@huamanraj huamanraj merged commit 2d78c30 into anuragverma108:main May 23, 2024
4 checks passed
@huamanraj huamanraj added gssoc This Contribution is under GirlScript Summer of Code 2024 level1 Basic labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc This Contribution is under GirlScript Summer of Code 2024 level1 Basic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: At login page the text and the login container is overlapping with each other .
2 participants