Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made the change in code to work the googleSignInbtn and facebookBtn properly #4739

Closed
wants to merge 1 commit into from

Conversation

sharath778
Copy link

Related Issue

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Fixes: 1

Description

The issue i solved is to work the google authentication button and facebook authentication button work independently but the popUp is not showing because it is need to configure by the admin in Firebase. When we inspect it is going to popup with error.

issue Number: #4645

Type of PR

  • Bug fix

Screenshots / videos (if applicable)

-Before fixing
image

-After fixing the button working
image

Checklist:

  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swapreads ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 6:28am

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for swapreadsconnect ready!

Name Link
🔨 Latest commit d763234
🔍 Latest deploy log https://app.netlify.com/sites/swapreadsconnect/deploys/672c5ddea8e4540008101bc1
😎 Deploy Preview https://deploy-preview-4739--swapreadsconnect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abhi03ruchi
Copy link
Collaborator

create demo video to show working ...

i am still getting Firebase: Error (auth/popup-blocked).

@atmajaa
Copy link
Collaborator

atmajaa commented Nov 10, 2024

@sharath778 today is the last date to contribute

Copy link
Contributor

This PR has been automatically closed due to inactivity from the owner for 15 days.

@github-actions github-actions bot added the Stale label Nov 26, 2024
@github-actions github-actions bot closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants