Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding pages to book recommendation #4518

Closed
wants to merge 4 commits into from

Conversation

Riyachauhan11
Copy link
Contributor

@Riyachauhan11 Riyachauhan11 commented Nov 3, 2024

Related Issue

None

Fixes: #4517

Description

I have added book recommendations for 3 different genres accessible from their cards on home page : historical fiction, self help and biography

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes. Make sure to attach before & after screenshots in your PR.]
382584627-90849547-67e1-452b-bcc3-c9468b7b96eb

Checklist:

  • [ X]I have made this change from my own.
  • I have taken help from some online resources.
  • [ X] My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Nov 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swapreads ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2024 3:45pm

Copy link
Contributor

github-actions bot commented Nov 3, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for swapreadsconnect ready!

Name Link
🔨 Latest commit 4eb2564
🔍 Latest deploy log https://app.netlify.com/sites/swapreadsconnect/deploys/67279a6af6aa740008f124e1
😎 Deploy Preview https://deploy-preview-4518--swapreadsconnect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Riyachauhan11
Copy link
Contributor Author

pls refresh the page on chrome for more genres to be visible if they arent visible

@abhi03ruchi
Copy link
Collaborator

abhi03ruchi commented Nov 3, 2024

a contributor is already working on this issue ( genre section ). if he doesnt raise pr within few days , will merge ur pr . i have asked him for updates .

@abhi03ruchi
Copy link
Collaborator

abhi03ruchi commented Nov 3, 2024

meanwhile , u can work on other issues , like enhancing events page . etc ...

@abhi03ruchi
Copy link
Collaborator

abhi03ruchi commented Nov 3, 2024

u can enhance the genre section on the home page . enhance the cards UI and add book recommendation button ( redirect user to. the page ) and delete the books given below it , as we have created a new page which contains book recommendations .
Screenshot 2024-11-03 at 11 54 40 PM

@Riyachauhan11
Copy link
Contributor Author

meanwhile , u can work on other issues , like enhancing events page . etc ...

ill discard this pr since he seems to have raised an issue for this and work on the events page

@Riyachauhan11
Copy link
Contributor Author

u can enhance the genre section on the home page . enhance the cards UI and add book recommendation button ( redirect user to. the page ) and delete the books given below it , as we have created a new page which contains book recommendations . Screenshot 2024-11-03 at 11 54 40 PM

ok ill try to work on this after the events page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: adding pages to book recommendation
2 participants