Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile secondary network OVS ports after Agent restart #6853

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KMAnju-2021
Copy link
Contributor

@KMAnju-2021 KMAnju-2021 commented Dec 11, 2024

Closes: #6578 #5623

Store the SecondaryNetwork interface in interfacestore after Agent restart and delete secondaryNetwork OVS ports correctly.

e2e case: -->

  1. restart the antrea agent
  2. check for the ovs ports restored or not
  3. delete the one testpod p1
  4. check pod p1 exist or not
  5. check for the stale ovs ports
  6. check for the pod ip (released or not)

@KMAnju-2021 KMAnju-2021 force-pushed the secondary-network-port branch 2 times, most recently from 63e028a to 3b7abe8 Compare December 11, 2024 19:15
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new tests are needed under test/e2e-secondary-network to validate this patch

@KMAnju-2021 KMAnju-2021 force-pushed the secondary-network-port branch 6 times, most recently from 3bf9b47 to 63d1231 Compare December 17, 2024 11:50
@rajnkamr rajnkamr added this to the Antrea v2.3 release milestone Dec 26, 2024
@KMAnju-2021 KMAnju-2021 force-pushed the secondary-network-port branch 3 times, most recently from 7904bea to 20ca6f4 Compare January 3, 2025 10:33
@KMAnju-2021 KMAnju-2021 force-pushed the secondary-network-port branch 3 times, most recently from 5e2b8e1 to 5e22752 Compare January 5, 2025 20:16
@luolanzone
Copy link
Contributor

@KMAnju-2021 I didn't see any new tests for the patch, re-post Antonin's comment:

new tests are needed under test/e2e-secondary-network to validate this patch

@KMAnju-2021 KMAnju-2021 force-pushed the secondary-network-port branch from 5e22752 to dd90f3c Compare January 16, 2025 10:26
@KMAnju-2021 KMAnju-2021 force-pushed the secondary-network-port branch from dd90f3c to e61f080 Compare January 20, 2025 11:35
@KMAnju-2021 KMAnju-2021 force-pushed the secondary-network-port branch 9 times, most recently from d8378fb to 26d0f08 Compare February 19, 2025 13:22
@KMAnju-2021 KMAnju-2021 requested a review from jianjuns February 19, 2025 13:35
@KMAnju-2021 KMAnju-2021 force-pushed the secondary-network-port branch 5 times, most recently from 9820a0c to 040073e Compare February 21, 2025 08:53
@jianjuns
Copy link
Contributor

I feel "Reconcile secondary network OVS ports after Agent restart" is a better name for the PR/commit.

@luolanzone luolanzone added the action/backport Indicates a PR that requires backports. label Feb 24, 2025
@KMAnju-2021 KMAnju-2021 force-pushed the secondary-network-port branch from 040073e to 6cad525 Compare February 24, 2025 10:23
@KMAnju-2021 KMAnju-2021 changed the title Delete secondaryNetwork OVS ports correctly after an Agent restart Reconcile secondary network OVS ports after Agent restart Feb 24, 2025
@KMAnju-2021 KMAnju-2021 force-pushed the secondary-network-port branch from 6cad525 to c130e90 Compare February 24, 2025 11:27
Signed-off-by: KMAnju-2021 <km074btcse18@igdtuw.ac.in>
@KMAnju-2021 KMAnju-2021 force-pushed the secondary-network-port branch from c130e90 to f42b147 Compare February 24, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/backport Indicates a PR that requires backports.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SecondaryNetwork OVS ports cannot be deleted correctly after an Agent restart
6 participants