Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate vmware_host #2337

Conversation

mariolenz
Copy link
Collaborator

@mariolenz mariolenz commented Feb 27, 2025

SUMMARY

Deprecate community.vmware.vmware_host in favor of vmware.vmware.esxi_host and vmware.vmware.esxi_connection.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_host

ADDITIONAL INFORMATION

ansible-collections/vmware.vmware#110

@mariolenz mariolenz force-pushed the deprecate-vmware_host branch from 782a66d to 0e413d6 Compare February 27, 2025 15:37
@mariolenz mariolenz closed this Feb 27, 2025
@mariolenz mariolenz reopened this Feb 27, 2025
@mariolenz mariolenz changed the title Deprecate vmware_host [WIP] Deprecate vmware_host Feb 27, 2025
@mariolenz mariolenz added the WIP Work in progress label Feb 27, 2025
@mariolenz mariolenz force-pushed the deprecate-vmware_host branch from 0e413d6 to 70e6d04 Compare February 27, 2025 15:43
@mariolenz mariolenz force-pushed the deprecate-vmware_host branch from 56686d2 to 274df41 Compare February 27, 2025 18:37
@mariolenz mariolenz force-pushed the deprecate-vmware_host branch from 274df41 to 1ee214f Compare February 28, 2025 15:30
@mariolenz
Copy link
Collaborator Author

mariolenz commented Feb 28, 2025

For the record:

2025-02-28 15:52:55.485974 | controller | TASK [prepare_vmware_tests : Add ESXi Hosts to vCenter] ************************
2025-02-28 15:52:55.485979 | controller | task path: /home/zuul/.ansible/collections/ansible_collections/community/vmware/tests/integration/targets/prepare_vmware_tests/tasks/setup_attach_hosts.yml:5
2025-02-28 15:52:55.485988 | controller | Including module_utils file ansible/__init__.py
2025-02-28 15:52:55.485992 | controller | Including module_utils file ansible/module_utils/__init__.py
2025-02-28 15:52:55.485996 | controller | Including module_utils file ansible/module_utils/_text.py
2025-02-28 15:52:55.486006 | controller | Including module_utils file ansible/module_utils/basic.py
2025-02-28 15:52:55.486011 | controller | Including module_utils file ansible/module_utils/common/_utils.py
2025-02-28 15:52:55.486015 | controller | Including module_utils file ansible/module_utils/common/__init__.py
2025-02-28 15:52:55.486019 | controller | Including module_utils file ansible/module_utils/common/arg_spec.py
2025-02-28 15:52:55.486023 | controller | Including module_utils file ansible/module_utils/common/file.py
2025-02-28 15:52:55.486027 | controller | Including module_utils file ansible/module_utils/common/locale.py
2025-02-28 15:52:55.486031 | controller | Including module_utils file ansible/module_utils/common/parameters.py
2025-02-28 15:52:55.486036 | controller | Including module_utils file ansible/module_utils/common/collections.py
2025-02-28 15:52:55.486040 | controller | Including module_utils file ansible/module_utils/common/process.py
2025-02-28 15:52:55.486044 | controller | Including module_utils file ansible/module_utils/common/sys_info.py
2025-02-28 15:52:55.486048 | controller | Including module_utils file ansible/module_utils/common/text/converters.py
2025-02-28 15:52:55.486052 | controller | Including module_utils file ansible/module_utils/common/text/__init__.py
2025-02-28 15:52:55.486056 | controller | Including module_utils file ansible/module_utils/common/text/formatters.py
2025-02-28 15:52:55.486060 | controller | Including module_utils file ansible/module_utils/common/validation.py
2025-02-28 15:52:55.486064 | controller | Including module_utils file ansible/module_utils/common/warnings.py
2025-02-28 15:52:55.486068 | controller | Including module_utils file ansible/module_utils/compat/selinux.py
2025-02-28 15:52:55.486072 | controller | Including module_utils file ansible/module_utils/compat/__init__.py
2025-02-28 15:52:55.486076 | controller | Including module_utils file ansible/module_utils/distro/__init__.py
2025-02-28 15:52:55.486080 | controller | Including module_utils file ansible/module_utils/distro/_distro.py
2025-02-28 15:52:55.486084 | controller | Including module_utils file ansible/module_utils/errors.py
2025-02-28 15:52:55.486088 | controller | Including module_utils file ansible/module_utils/parsing/convert_bool.py
2025-02-28 15:52:55.486092 | controller | Including module_utils file ansible/module_utils/parsing/__init__.py
2025-02-28 15:52:55.486096 | controller | Including module_utils file ansible/module_utils/pycompat24.py
2025-02-28 15:52:55.486100 | controller | Including module_utils file ansible/module_utils/six/__init__.py
2025-02-28 15:52:55.486104 | controller | Including module_utils file ansible_collections/vmware/vmware/plugins/module_utils/_module_pyvmomi_base.py
2025-02-28 15:52:55.486112 | controller | Including module_utils file ansible_collections/__init__.py
2025-02-28 15:52:55.486117 | controller | Including module_utils file ansible_collections/vmware/__init__.py
2025-02-28 15:52:55.486121 | controller | Including module_utils file ansible_collections/vmware/vmware/__init__.py
2025-02-28 15:52:55.486125 | controller | Including module_utils file ansible_collections/vmware/vmware/plugins/__init__.py
2025-02-28 15:52:55.486129 | controller | Including module_utils file ansible_collections/vmware/vmware/plugins/module_utils/__init__.py
2025-02-28 15:52:55.486133 | controller | Including module_utils file ansible_collections/vmware/vmware/plugins/module_utils/_vmware_argument_spec.py
2025-02-28 15:52:55.486137 | controller | Including module_utils file ansible_collections/vmware/vmware/plugins/module_utils/_vmware_folder_paths.py
2025-02-28 15:52:55.486142 | controller | Including module_utils file ansible_collections/vmware/vmware/plugins/module_utils/_vmware_tasks.py
2025-02-28 15:52:55.486146 | controller | Including module_utils file ansible_collections/vmware/vmware/plugins/module_utils/clients/_pyvmomi.py
2025-02-28 15:52:55.486150 | controller | Including module_utils file ansible_collections/vmware/vmware/plugins/module_utils/clients/__init__.py
2025-02-28 15:52:55.486154 | controller | Including module_utils file ansible_collections/vmware/vmware/plugins/module_utils/clients/_errors.py
2025-02-28 15:52:55.486158 | controller | Using module file /home/zuul/.ansible/collections/ansible_collections/vmware/vmware/plugins/modules/esxi_host.py
2025-02-28 15:52:55.486162 | controller | Pipelining is enabled.
2025-02-28 15:52:55.486166 | controller | <testhost> ESTABLISH LOCAL CONNECTION FOR USER: zuul
2025-02-28 15:52:55.486172 | controller | <testhost> EXEC /bin/sh -c '/home/zuul/venv/bin/python && sleep 0'
2025-02-28 15:52:55.486178 | controller | The full traceback is:
2025-02-28 15:52:55.486182 | controller | Traceback (most recent call last):
2025-02-28 15:52:55.486186 | controller |   File "/tmp/ansible_vmware.vmware.esxi_host_payload_2rx44t2p/ansible_vmware.vmware.esxi_host_payload.zip/ansible_collections/vmware/vmware/plugins/module_utils/clients/_pyvmomi.py", line 154, in __create_service_instance
2025-02-28 15:52:55.486191 | controller |   File "/home/zuul/venv/lib/python3.11/site-packages/pyVim/connect.py", line 985, in SmartConnect
2025-02-28 15:52:55.486195 | controller |     supportedVersion = __FindSupportedVersion(protocol, host, port, path,
2025-02-28 15:52:55.486199 | controller |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2025-02-28 15:52:55.486203 | controller |   File "/home/zuul/venv/lib/python3.11/site-packages/pyVim/connect.py", line 790, in __FindSupportedVersion
2025-02-28 15:52:55.486207 | controller |     serviceVersionDescription = __GetServiceVersionDescription(
2025-02-28 15:52:55.486211 | controller |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2025-02-28 15:52:55.486215 | controller |   File "/home/zuul/venv/lib/python3.11/site-packages/pyVim/connect.py", line 714, in __GetServiceVersionDescription
2025-02-28 15:52:55.486219 | controller |     return __GetElementTree(protocol, server, port,
2025-02-28 15:52:55.486227 | controller |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2025-02-28 15:52:55.597442 | controller |   File "/home/zuul/venv/lib/python3.11/site-packages/pyVim/connect.py", line 668, in __GetElementTree
2025-02-28 15:52:55.597455 | controller |     conn.request(method="GET", url=path, headers=headers)
2025-02-28 15:52:55.597460 | controller |   File "/usr/lib64/python3.11/http/client.py", line 1282, in request
2025-02-28 15:52:55.597464 | controller |     self._send_request(method, url, body, headers, encode_chunked)
2025-02-28 15:52:55.597468 | controller |   File "/usr/lib64/python3.11/http/client.py", line 1328, in _send_request
2025-02-28 15:52:55.597472 | controller |     self.endheaders(body, encode_chunked=encode_chunked)
2025-02-28 15:52:55.597476 | controller |   File "/usr/lib64/python3.11/http/client.py", line 1277, in endheaders
2025-02-28 15:52:55.597481 | controller |     self._send_output(message_body, encode_chunked=encode_chunked)
2025-02-28 15:52:55.597485 | controller |   File "/usr/lib64/python3.11/http/client.py", line 1037, in _send_output
2025-02-28 15:52:55.597489 | controller |     self.send(msg)
2025-02-28 15:52:55.597497 | controller |   File "/usr/lib64/python3.11/http/client.py", line 975, in send
2025-02-28 15:52:55.597501 | controller |     self.connect()
2025-02-28 15:52:55.597505 | controller |   File "/usr/lib64/python3.11/http/client.py", line 1454, in connect
2025-02-28 15:52:55.597509 | controller |     self.sock = self._context.wrap_socket(self.sock,
2025-02-28 15:52:55.597513 | controller |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2025-02-28 15:52:55.597517 | controller |   File "/usr/lib64/python3.11/ssl.py", line 517, in wrap_socket
2025-02-28 15:52:55.597522 | controller |     return self.sslsocket_class._create(
2025-02-28 15:52:55.597526 | controller |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2025-02-28 15:52:55.597530 | controller |   File "/usr/lib64/python3.11/ssl.py", line 1075, in _create
2025-02-28 15:52:55.597534 | controller |     self.do_handshake()
2025-02-28 15:52:55.597538 | controller |   File "/usr/lib64/python3.11/ssl.py", line 1346, in do_handshake
2025-02-28 15:52:55.597542 | controller |     self._sslobj.do_handshake()
2025-02-28 15:52:55.597546 | controller | ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:992)
2025-02-28 15:52:55.597551 | controller |
2025-02-28 15:52:55.597556 | controller | During handling of the above exception, another exception occurred:
2025-02-28 15:52:55.597560 | controller |
2025-02-28 15:52:55.597564 | controller | Traceback (most recent call last):
2025-02-28 15:52:55.597568 | controller |   File "<stdin>", line 121, in <module>
2025-02-28 15:52:55.597572 | controller |   File "<stdin>", line 113, in _ansiballz_main
2025-02-28 15:52:55.597576 | controller |   File "<stdin>", line 61, in invoke_module
2025-02-28 15:52:55.597581 | controller |   File "<frozen runpy>", line 226, in run_module
2025-02-28 15:52:55.597585 | controller |   File "<frozen runpy>", line 98, in _run_module_code
2025-02-28 15:52:55.597592 | controller |   File "<frozen runpy>", line 88, in _run_code
2025-02-28 15:52:55.597597 | controller |   File "/tmp/ansible_vmware.vmware.esxi_host_payload_2rx44t2p/ansible_vmware.vmware.esxi_host_payload.zip/ansible_collections/vmware/vmware/plugins/modules/esxi_host.py", line 415, in <module>
2025-02-28 15:52:55.597601 | controller |   File "/tmp/ansible_vmware.vmware.esxi_host_payload_2rx44t2p/ansible_vmware.vmware.esxi_host_payload.zip/ansible_collections/vmware/vmware/plugins/modules/esxi_host.py", line 394, in main
2025-02-28 15:52:55.597606 | controller |   File "/tmp/ansible_vmware.vmware.esxi_host_payload_2rx44t2p/ansible_vmware.vmware.esxi_host_payload.zip/ansible_collections/vmware/vmware/plugins/modules/esxi_host.py", line 188, in __init__
2025-02-28 15:52:55.597610 | controller |   File "/tmp/ansible_vmware.vmware.esxi_host_payload_2rx44t2p/ansible_vmware.vmware.esxi_host_payload.zip/ansible_collections/vmware/vmware/plugins/module_utils/_module_pyvmomi_base.py", line 23, in __init__
2025-02-28 15:52:55.597618 | controller |   File "/tmp/ansible_vmware.vmware.esxi_host_payload_2rx44t2p/ansible_vmware.vmware.esxi_host_payload.zip/ansible_collections/vmware/vmware/plugins/module_utils/clients/_pyvmomi.py", line 36, in __init__
2025-02-28 15:52:55.597622 | controller |   File "/tmp/ansible_vmware.vmware.esxi_host_payload_2rx44t2p/ansible_vmware.vmware.esxi_host_payload.zip/ansible_collections/vmware/vmware/plugins/module_utils/clients/_pyvmomi.py", line 79, in connect_to_api
2025-02-28 15:52:55.597626 | controller |   File "/tmp/ansible_vmware.vmware.esxi_host_payload_2rx44t2p/ansible_vmware.vmware.esxi_host_payload.zip/ansible_collections/vmware/vmware/plugins/module_utils/clients/_pyvmomi.py", line 167, in __create_service_instance
2025-02-28 15:52:55.597631 | controller | ansible_collections.vmware.vmware.plugins.module_utils.clients._errors.ApiAccessError: Unable to connect to the vCenter or ESXi API at vcenter.test on TCP/443: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:992)

@mariolenz mariolenz force-pushed the deprecate-vmware_host branch from 1ee214f to 56087c2 Compare March 1, 2025 11:50
@mariolenz
Copy link
Collaborator Author

recheck

@mariolenz
Copy link
Collaborator Author

recheck

@mariolenz
Copy link
Collaborator Author

recheck

@mariolenz
Copy link
Collaborator Author

recheck

@mariolenz
Copy link
Collaborator Author

recheck

@mariolenz mariolenz force-pushed the deprecate-vmware_host branch from 3bc5d5d to 9db9b6b Compare March 3, 2025 10:09
@mariolenz
Copy link
Collaborator Author

recheck

@mariolenz mariolenz removed the WIP Work in progress label Mar 3, 2025
@mariolenz mariolenz changed the title [WIP] Deprecate vmware_host Deprecate vmware_host Mar 3, 2025
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/43f7cce369594c4b9aa6145876a463c3

✔️ ansible-tox-linters SUCCESS in 5m 09s
✔️ build-ansible-collection SUCCESS in 6m 21s
✔️ ansible-galaxy-importer SUCCESS in 4m 20s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 9011b8e into ansible-collections:main Mar 3, 2025
13 checks passed
@mariolenz mariolenz deleted the deprecate-vmware_host branch March 3, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants