[DNM] Test removing unused methods / functions

[mariolenz]

SUMMARY

DO NOT MERGE!

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

plugins/module_utils/vm_device_helper.py
plugins/module_utils/vmware.py
plugins/module_utils/vmware_rest_client.py

ADDITIONAL INFORMATION

I only find the definitions but no usage:

~/github/community.vmware$ egrep -r '(is_nvdimm_controller|is_nvdimm_device|find_host_portgroup_by_name|find_host_portgroup_by_name|network_exists_by_name|vmdk_disk_path_split|find_vmdk_file|get_folder_by_name)' plugins/
plugins/module_utils/vmware_rest_client.py:    def get_folder_by_name(self, datacenter_name, folder_name):
plugins/module_utils/vm_device_helper.py:    def is_nvdimm_controller(device):
plugins/module_utils/vm_device_helper.py:    def is_nvdimm_device(device):
plugins/module_utils/vmware.py:def find_host_portgroup_by_name(host, portgroup_name):
plugins/module_utils/vmware.py:    def find_host_portgroup_by_name(host, portgroup_name):
plugins/module_utils/vmware.py:    def network_exists_by_name(self, network_name=None):
plugins/module_utils/vmware.py:    def vmdk_disk_path_split(self, vmdk_path):
plugins/module_utils/vmware.py:    def find_vmdk_file(self, datastore_obj, vmdk_fullpath, vmdk_filename, vmdk_folder):
~/github/community.vmware$

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/3cc1e4cdd50a44f299a431bab9d57fd7

❌ ansible-tox-linters FAILURE in 4m 19s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

[mariolenz]

LOL! We don't use vmdk_disk_path_split anywhere but we do have a unit test for it 😆

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a2a586154ba14bf389eeaffc3df5e5a1

✔️ ansible-tox-linters SUCCESS in 4m 31s
✔️ build-ansible-collection SUCCESS in 7m 20s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable218 FAILURE in 13m 17s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 23s

[mariolenz]

recheck

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a03bb2c967bd487bb2348c75e067bf88

✔️ ansible-tox-linters SUCCESS in 4m 33s
✔️ build-ansible-collection SUCCESS in 7m 26s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 FAILURE in 12m 15s
✔️ ansible-galaxy-importer SUCCESS in 3m 10s

[mariolenz]

recheck

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/c8b6a70683984a5089b567b2320aa463

✔️ ansible-tox-linters SUCCESS in 4m 50s
✔️ build-ansible-collection SUCCESS in 8m 04s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 FAILURE in 13m 24s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 02s

[mariolenz]

License not available to perform the operationlooks familiar: #1723

@alinabuzachis @jillr Do you think you could fix this quick'n'dirty? Or do you think there's a better solution to using Zuul (#1746 ansible/zuul-config#587 (comment))?

cc @mikemorency

[alinabuzachis]

License not available to perform the operationlooks familiar: #1723

@alinabuzachis @jillr Do you think you could fix this quick'n'dirty? Or do you think there's a better solution to using Zuul (#1746 ansible/zuul-config#587 (comment))?

cc @mikemorency

I will work on it today and let you know.

[alinabuzachis]

recheck

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/4b35a76eca764587b524a2f6fd60dd6e

✔️ ansible-tox-linters SUCCESS in 4m 22s
✔️ build-ansible-collection SUCCESS in 7m 41s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 FAILURE in 8m 00s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 09s

[alinabuzachis]

recheck

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6590cd8754b94ca4acd33b9e9daf6d12

✔️ ansible-tox-linters SUCCESS in 4m 37s
✔️ build-ansible-collection SUCCESS in 7m 39s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 16m 40s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 14m 43s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SUCCESS in 45m 43s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SUCCESS in 59m 01s
✔️ ansible-galaxy-importer SUCCESS in 3m 16s

[mariolenz]

Thank you very much @alinabuzachis!