Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware_guest_tools_info: Use toolsVersionStatus2 #2034

Merged
merged 2 commits into from
Apr 11, 2024
Merged

vmware_guest_tools_info: Use toolsVersionStatus2 #2034

merged 2 commits into from
Apr 11, 2024

Conversation

mariolenz
Copy link
Collaborator

@mariolenz mariolenz commented Mar 25, 2024 •
edited
Loading

Fixes #2033

SUMMARY

toolsVersionStatus is deprecated and toolsVersionStatus2 should be used.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_guest_tools_info

ADDITIONAL INFORMATION

I've just seen that toolsStatus is also deprecated. But removing it would be a breaking change... I'll mark this PR WIP until I know what to do about it.
Let's deprecate vm_tools_install_status in favour of vm_tools_running_status / vm_tools_version_status as an alternative.

@mariolenz mariolenz added the WIP Work in progress label Mar 25, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/838be87997e947399073b0f48312ed75

✔️ ansible-tox-linters SUCCESS in 12m 33s
✔️ build-ansible-collection SUCCESS in 12m 21s
✔️ ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 21m 21s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable216 FAILURE in 22m 32s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 12s

@mariolenz
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/62f73f32d5d145b18d8db0697034f3ed

✔️ ansible-tox-linters SUCCESS in 10m 41s
✔️ build-ansible-collection SUCCESS in 11m 17s
✔️ ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 23m 23s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 19m 43s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 54m 42s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 59m 00s
✔️ ansible-galaxy-importer SUCCESS in 5m 34s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c166d98d63724ce0af6aacb1bb9895bf

✔️ ansible-tox-linters SUCCESS in 11m 41s
✔️ build-ansible-collection SUCCESS in 11m 11s
✔️ ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 22m 38s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 22m 33s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 56m 22s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 59m 59s
✔️ ansible-galaxy-importer SUCCESS in 3m 59s

@mariolenz mariolenz changed the title [WIP] vmware_guest_tools_info: Use toolsVersionStatus2 vmware_guest_tools_info: Use toolsVersionStatus2 Apr 2, 2024
@mariolenz mariolenz added feature This issue/PR relates to a feature request has_issue deprecated and removed WIP Work in progress labels Apr 2, 2024
@mariolenz
Copy link
Collaborator Author

@ihumster What do you think about his?

@mariolenz
Copy link
Collaborator Author

@ihumster What do you think about this. Should we merge?

BTW if you approve, please also try to add the mergeit label. You should have the permissions to do it and then this PR should be merged automatically.

ihumster
ihumster approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@ihumster ihumster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@mariolenz
Copy link
Collaborator Author

Thanks for reviewing @ihumster!

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/f7d2136847234ee8b71afb5d83e88c54

✔️ ansible-tox-linters SUCCESS in 10m 29s
✔️ build-ansible-collection SUCCESS in 8m 10s
✔️ ansible-galaxy-importer SUCCESS in 5m 13s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@mariolenz mariolenz merged commit 2f2fcb4 into ansible-collections:main Apr 11, 2024
13 checks passed
@mariolenz mariolenz deleted the issue2033 branch April 11, 2024 17:35
@mariolenz mariolenz mentioned this pull request May 19, 2024
Closed
@mariolenz mariolenz mentioned this pull request Sep 14, 2024
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Sep 15, 2024
@mariolenz
vmware_guest_tools_info: Remove vm_tools_install_status (#2166)
fd308f4 
Fixes #2078
SUMMARY
Removing vm_tools_install_status which reports the deprecated toolsStatus as announced in #2034.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
vmware_guest_tools_info
ADDITIONAL INFORMATION
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihumster ihumster ihumster approved these changes

Assignees

@ihumster ihumster

Labels
deprecated feature This issue/PR relates to a feature request has_issue mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use toolsVersionStatus2 instead of toolsVersionStatus
2 participants
@mariolenz @ihumster