-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Pylint errors in CI #2011
Fix Pylint errors in CI #2011
Conversation
Nice! Getting rid of python anachronisms =) |
de8e0e6
to
3cfa294
Compare
Yep, I think it's better to fix those Pylint issues instead of just ignoring them. Those tests in the CI (usually) are there for a reason :-) |
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 11m 08s |
Build succeeded (gate pipeline). ✔️ ansible-tox-linters SUCCESS in 9m 55s |
522b4a1
into
ansible-collections:main
stable-3.x: Fix Pylint errors in CI SUMMARY Fix the following Pylint errors in the CI: ERROR: plugins/module_utils/vmware.py:1091:13: unidiomatic-typecheck: Use isinstance() rather than type() for a typecheck. ERROR: plugins/module_utils/vmware.py:1093:13: unidiomatic-typecheck: Use isinstance() rather than type() for a typecheck. ERROR: plugins/module_utils/vmware.py:1095:13: unidiomatic-typecheck: Use isinstance() rather than type() for a typecheck. ERROR: scripts/inventory/vmware_inventory.py:286:11: unidiomatic-typecheck: Use isinstance() rather than type() for a typecheck. ERROR: tests/unit/mock/loader.py:33:15: unidiomatic-typecheck: Use isinstance() rather than type() for a typecheck. ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/module_utils/vmware.py scripts/inventory/vmware_inventory.py tests/unit/mock/loader.py ADDITIONAL INFORMATION #2011
SUMMARY
Fix the following Pylint errors in the CI:
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/vmware.py
scripts/inventory/vmware_inventory.py
tests/unit/mock/loader.py
ADDITIONAL INFORMATION