Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pylint errors in CI #2011

Conversation

mariolenz
Copy link
Collaborator

SUMMARY

Fix the following Pylint errors in the CI:

ERROR: plugins/module_utils/vmware.py:1091:13: unidiomatic-typecheck: Use isinstance() rather than type() for a typecheck.
ERROR: plugins/module_utils/vmware.py:1093:13: unidiomatic-typecheck: Use isinstance() rather than type() for a typecheck.
ERROR: plugins/module_utils/vmware.py:1095:13: unidiomatic-typecheck: Use isinstance() rather than type() for a typecheck.
ERROR: scripts/inventory/vmware_inventory.py:286:11: unidiomatic-typecheck: Use isinstance() rather than type() for a typecheck.
ERROR: tests/unit/mock/loader.py:33:15: unidiomatic-typecheck: Use isinstance() rather than type() for a typecheck.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/module_utils/vmware.py
scripts/inventory/vmware_inventory.py
tests/unit/mock/loader.py

ADDITIONAL INFORMATION

@ihumster
Copy link
Collaborator

Nice! Getting rid of python anachronisms =)

@mariolenz
Copy link
Collaborator Author

Yep, I think it's better to fix those Pylint issues instead of just ignoring them. Those tests in the CI (usually) are there for a reason :-)

@mariolenz mariolenz added CI CI related issues mergeit labels Feb 27, 2024
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/b6439c0c33c94c8b95ecfe077ca5fc21

✔️ ansible-tox-linters SUCCESS in 9m 55s
✔️ build-ansible-collection SUCCESS in 8m 28s
✔️ ansible-galaxy-importer SUCCESS in 5m 11s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 522b4a1 into ansible-collections:main Feb 27, 2024
13 checks passed
@mariolenz mariolenz deleted the 2024027_fix_ci branch February 27, 2024 18:18
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 27, 2024
stable-3.x: Fix Pylint errors in CI

SUMMARY
Fix the following Pylint errors in the CI:
ERROR: plugins/module_utils/vmware.py:1091:13: unidiomatic-typecheck: Use isinstance() rather than type() for a typecheck.
ERROR: plugins/module_utils/vmware.py:1093:13: unidiomatic-typecheck: Use isinstance() rather than type() for a typecheck.
ERROR: plugins/module_utils/vmware.py:1095:13: unidiomatic-typecheck: Use isinstance() rather than type() for a typecheck.
ERROR: scripts/inventory/vmware_inventory.py:286:11: unidiomatic-typecheck: Use isinstance() rather than type() for a typecheck.
ERROR: tests/unit/mock/loader.py:33:15: unidiomatic-typecheck: Use isinstance() rather than type() for a typecheck.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
plugins/module_utils/vmware.py
scripts/inventory/vmware_inventory.py
tests/unit/mock/loader.py
ADDITIONAL INFORMATION
#2011
mariolenz added a commit to mariolenz/vmware.vmware that referenced this pull request Apr 14, 2024
bardielle pushed a commit to ansible-collections/vmware.vmware that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI related issues mergeit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants