Fix errors occuring during hardware version upgrade not being reported (fixes #2001)

[Yannik]

SUMMARY

This fixes #2001.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

vmware_guest

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/74529f2dac2b4b2fbe007404e16a055f

✔️ ansible-tox-linters SUCCESS in 11m 32s
✔️ build-ansible-collection SUCCESS in 11m 38s
✔️ ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 21m 39s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 22m 21s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 48m 33s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 1h 03m 24s
✔️ ansible-galaxy-importer SUCCESS in 5m 38s

[Yannik]

@mariolenz I'd appreciate to get this merged.

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/9d1c2168779d436bbe990f9bea7a3e0f

✔️ ansible-tox-linters SUCCESS in 8m 17s
✔️ build-ansible-collection SUCCESS in 8m 34s
✔️ ansible-test-cloud-integration-vcenter7_only-stable217 SUCCESS in 22m 07s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable217 SUCCESS in 13m 56s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_1_of_2 SUCCESS in 51m 53s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_2_of_2 SUCCESS in 58m 59s
✔️ ansible-galaxy-importer SUCCESS in 4m 53s

[mariolenz]

Sorry, I've overlooked this PR for far too long. I think we had some changes to the module. Could you please re-base your fork just to make sure there are no merge conflicts?

[Yannik]

@mariolenz I have rebased and checked if anything logic-wise changed that impacts this PR. That is not the case.

During reviewing this, I noticed something else. Instead of propagating the error return code up the stack, , it would also be possible to change this line:

community.vmware/plugins/modules/vmware_guest.py

Line 1640 in b2a4a4c

return {'changed': self.change_applied, 'failed': True, 'msg': task.info.error.msg, 'op': 'upgrade'}

to a self.module.fail_json.

Which method to fix this do you prefer?

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/9b37db5aa9f54ed1afa4748c936930cb

✔️ ansible-tox-linters SUCCESS in 4m 48s
✔️ build-ansible-collection SUCCESS in 7m 24s
✔️ ansible-test-cloud-integration-vcenter7_only-stable217 SUCCESS in 16m 43s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable217 SUCCESS in 13m 26s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_1_of_2 SUCCESS in 1h 07m 52s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_2_of_2 SUCCESS in 56m 12s
✔️ ansible-galaxy-importer SUCCESS in 5m 32s

[mariolenz]

LGTM

[softwarefactory-project-zuul]

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/6e7f311e54694b23b63ccec670a8d48c

✔️ ansible-tox-linters SUCCESS in 4m 45s
✔️ build-ansible-collection SUCCESS in 6m 00s
✔️ ansible-galaxy-importer SUCCESS in 5m 17s