Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware_vmkernel - add enable_backup_nfc setting #1979

Merged
merged 4 commits into from
Feb 19, 2024
Merged

vmware_vmkernel - add enable_backup_nfc setting #1979

merged 4 commits into from
Feb 19, 2024

Conversation

Nina2244
Copy link
Contributor

SUMMARY

Add the possibility to set the enable_backup_nfc setting.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_vmkernel.py

ADDITIONAL INFORMATION

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/6487fd6ec85244a4b2724416ea1412ec

❌ ansible-tox-linters FAILURE in 11m 35s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable216 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/399fd804701c41ea8ff3905fdb2688e3

✔️ ansible-tox-linters SUCCESS in 9m 46s
✔️ build-ansible-collection SUCCESS in 10m 18s
✔️ ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 18m 53s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 18m 46s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 59m 16s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 47m 46s
✔️ ansible-galaxy-importer SUCCESS in 9m 41s

mariolenz
mariolenz approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @Nina2244!

@mariolenz mariolenz added feature This issue/PR relates to a feature request mergeit labels Feb 19, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/ebbf900edc3c44a392689ada7a43fe38

✔️ ansible-tox-linters SUCCESS in 9m 33s
✔️ build-ansible-collection SUCCESS in 8m 24s
✔️ ansible-galaxy-importer SUCCESS in 5m 16s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit c57244c into ansible-collections:main Feb 19, 2024
11 checks passed
@mariolenz mariolenz mentioned this pull request Feb 19, 2024
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 20, 2024
@mariolenz
vmware_vmkernel: Add missing version_added (#2003)
e09b9e1 
vmware_vmkernel: Add missing version_added

SUMMARY
This is a follow-up PR to #1979 to add the missing version_added.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
vmware_vmkernel
cc @Nina2244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariolenz mariolenz mariolenz approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nina2244 @mariolenz