Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subproperties option to vmware_vm_inventory #1972

Merged

Conversation

MaximilianClemens
Copy link
Contributor

SUMMARY

This Change adds an option 'subproperties' to the vmware_vm_inventory plugin.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_vm_inventory

ADDITIONAL INFORMATION
# Gather subproperties such as the parent (mostly cluster) of an ESXi
plugin: community.vmware.vmware_vm_inventory
strict: false
hostname: 10.65.223.31
username: administrator@vsphere.local
password: Esxi@123$%
validate_certs: false
properties:
- 'name'
- 'guest.ipAddress'
- 'config.name'
- 'config.uuid'
subproperties:
- property: 'summary.runtime.host'
  subelements:
  - 'name'
  - 'parent.name'

@BillyTheBadOne
Copy link

Very well appreciated add on!!!

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7b3aeac44e334d94aa0da4e316d6c7a8

✔️ ansible-tox-linters SUCCESS in 9m 45s
✔️ build-ansible-collection SUCCESS in 10m 26s
✔️ ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 21m 49s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 21m 12s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 52m 57s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 51m 55s
✔️ ansible-galaxy-importer SUCCESS in 3m 50s

@MaximilianClemens MaximilianClemens changed the title Add subpropeties option to vmware_vm_inventory Add subproperties option to vmware_vm_inventory Jan 28, 2024
@mariolenz
Copy link
Collaborator

@MaximilianClemens Sorry for the late reply, I didn't find the time to work on the PRs in this collection for some time :-(

I'm not very familiar with the inventory code, but as far as I can see your changes look OK.

Please add a changelog fragment, maybe changelogs/fragments/1972-vmware_guest_tools_upgrade.yml:

minor_changes:
  - vmware_vm_inventory - Add parameter `subproperties` (https://github.com/ansible-collections/community.vmware/pull/1972).

@mariolenz mariolenz added the feature This issue/PR relates to a feature request label Feb 11, 2024
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't I didn't find the time to test this, bu the code LGTM.

Thanks @MaximilianClemens!

Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/8a36e2e6afa94e6790be889b70286b49

✔️ ansible-tox-linters SUCCESS in 9m 33s
✔️ build-ansible-collection SUCCESS in 7m 51s
✔️ ansible-galaxy-importer SUCCESS in 18m 53s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 79118e3 into ansible-collections:main Feb 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request mergeit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants