-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subproperties option to vmware_vm_inventory #1972
Add subproperties option to vmware_vm_inventory #1972
Conversation
Very well appreciated add on!!! |
Build failed. ❌ ansible-tox-linters FAILURE in 9m 40s |
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 9m 45s |
@MaximilianClemens Sorry for the late reply, I didn't find the time to work on the PRs in this collection for some time :-( I'm not very familiar with the inventory code, but as far as I can see your changes look OK. Please add a changelog fragment, maybe
|
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 10m 15s |
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 9m 42s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't I didn't find the time to test this, bu the code LGTM.
Thanks @MaximilianClemens!
Build succeeded (gate pipeline). ✔️ ansible-tox-linters SUCCESS in 9m 33s |
79118e3
into
ansible-collections:main
SUMMARY
This Change adds an option 'subproperties' to the vmware_vm_inventory plugin.
ISSUE TYPE
COMPONENT NAME
vmware_vm_inventory
ADDITIONAL INFORMATION