Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement encryption configuration for vm vmotion and ft #1779

Merged
merged 5 commits into from
Jul 26, 2023
Merged

Implement encryption configuration for vm vmotion and ft #1779

merged 5 commits into from
Jul 26, 2023

Conversation

Alestor
Copy link
Contributor

@Alestor Alestor commented Jun 22, 2023 •
edited by mariolenz
Loading

SUMMARY

Fixes #1069

Implements the ability to configured vm encryption settings for vmotion or fault tolerance

image

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_guest

ADDITIONAL INFORMATION

Fulfill requirements of #1069

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e9d9ff2bdde0410bbe40eaf81a9068ee

❌ ansible-tox-linters FAILURE in 8m 54s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/eeb08fc65f3f41278ab5cf5aadc05593

✔️ ansible-tox-linters SUCCESS in 8m 47s
✔️ build-ansible-collection SUCCESS in 9m 19s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 23m 14s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 21m 06s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 58m 09s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 59m 26s
✔️ ansible-galaxy-importer SUCCESS in 3m 50s

mariolenz
mariolenz requested changes Jul 1, 2023
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alestor Please add a changelog fragment similar to this one. Maybe something like:

minor_changes:
  - vmware_guest - add support for configuring vMotion and FT encryption (https://github.com/ansible-collections/community.vmware/issues/1069)

@mariolenz
Copy link
Collaborator

Please add a changelog fragment similar to this one. Maybe something like:

minor_changes:
  - vmware_guest - add support for configuring vMotion and FT encryption (https://github.com/ansible-collections/community.vmware/issues/1069)

@Alestor Never mind, I already did. That is, if it's OK for you. Feel free to change it if you don't like my text 😃

BTW: I've just realized you've used your main branch for this PR. I really think you should consider feature branches for this in the future. It doesn't really make a difference for us, but it should make live a bit easier for you.

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/4e773286d3994d449052c0420dae49dd

✔️ ansible-tox-linters SUCCESS in 8m 33s
✔️ build-ansible-collection SUCCESS in 9m 11s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 21m 55s
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 FAILURE in 27m 14s
✔️ ansible-galaxy-importer SUCCESS in 3m 50s

@mariolenz
Copy link
Collaborator

recheck

@Alestor
Copy link
Contributor Author

Alestor commented Jul 1, 2023

Text is fine, thanks for your support on this PR.

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/cba81b959d0b4cf8aca02f0cd8152579

✔️ ansible-tox-linters SUCCESS in 8m 44s
✔️ build-ansible-collection SUCCESS in 9m 18s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 22m 04s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 19m 11s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 55m 28s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 FAILURE in 28m 03s
✔️ ansible-galaxy-importer SUCCESS in 3m 55s

@mariolenz mariolenz closed this Jul 1, 2023
@mariolenz mariolenz reopened this Jul 1, 2023
@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/4072d0878bda45cdbb2f33cacffa25af

✔️ ansible-tox-linters SUCCESS in 8m 34s
✔️ build-ansible-collection SUCCESS in 9m 16s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 FAILURE in 16m 38s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 NODE_FAILURE Node request 200-0006165419 failed in 0s
✔️ ansible-galaxy-importer SUCCESS in 3m 57s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/4458b30d5ba542089b753a9367492171

✔️ ansible-tox-linters SUCCESS in 8m 32s
✔️ build-ansible-collection SUCCESS in 9m 25s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 22m 29s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 21m 12s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 FAILURE in 1h 08m 26s
✔️ ansible-galaxy-importer SUCCESS in 3m 40s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/ef2260c16fcf46639c10ab337a6ec4a1

✔️ ansible-tox-linters SUCCESS in 8m 32s
✔️ build-ansible-collection SUCCESS in 9m 19s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 FAILURE in 32m 21s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 NODE_FAILURE Node request 200-0006166302 failed in 0s
✔️ ansible-galaxy-importer SUCCESS in 4m 08s

@Alestor
Copy link
Contributor Author

Alestor commented Jul 2, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/044e356ed4064a119de5d862372fdcf8

✔️ ansible-tox-linters SUCCESS in 8m 34s
✔️ build-ansible-collection SUCCESS in 9m 13s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 22m 31s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 20m 36s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 56m 08s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 RETRY_LIMIT in 1h 04m 10s
✔️ ansible-galaxy-importer SUCCESS in 3m 53s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d77b6b1cf22f477994affaf82c596647

✔️ ansible-tox-linters SUCCESS in 8m 28s
✔️ build-ansible-collection SUCCESS in 9m 21s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 FAILURE in 17m 30s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 NODE_FAILURE Node request 200-0006166789 failed in 0s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 51s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b036dca11cdf4049a9ec683192554683

✔️ ansible-tox-linters SUCCESS in 8m 28s
✔️ build-ansible-collection SUCCESS in 9m 09s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 22m 04s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 19m 44s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 57m 53s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 FAILURE in 49m 06s
✔️ ansible-galaxy-importer SUCCESS in 3m 29s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b271870478c44f9685e32abddd94819d

✔️ ansible-tox-linters SUCCESS in 8m 47s
✔️ build-ansible-collection SUCCESS in 9m 30s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 NODE_FAILURE Node request 200-0006167014 failed in 0s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 FAILURE in 14m 33s
✔️ ansible-galaxy-importer SUCCESS in 3m 52s

@Alestor
Copy link
Contributor Author

Alestor commented Jul 2, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a284253997ec4fc083a913fbf8eb53b7

✔️ ansible-tox-linters SUCCESS in 8m 30s
✔️ build-ansible-collection SUCCESS in 9m 18s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 FAILURE in 17m 44s
✔️ ansible-galaxy-importer SUCCESS in 4m 10s

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/edc7cf7faa914538996d523ed96745b0

✔️ ansible-tox-linters SUCCESS in 8m 47s
✔️ build-ansible-collection SUCCESS in 10m 25s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 19m 04s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 NODE_FAILURE Node request 200-0006227023 failed in 0s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 49m 44s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 NODE_FAILURE Node request 200-0006226677 failed in 0s
✔️ ansible-galaxy-importer SUCCESS in 6m 05s

@mariolenz mariolenz closed this Jul 25, 2023
@mariolenz mariolenz reopened this Jul 25, 2023
@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d8ce708957564510abedc04ab203c595

✔️ ansible-tox-linters SUCCESS in 8m 48s
✔️ build-ansible-collection SUCCESS in 9m 51s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 19m 13s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 NODE_FAILURE Node request 200-0006227632 failed in 0s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 NODE_FAILURE Node request 200-0006227848 failed in 0s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 52m 36s
✔️ ansible-galaxy-importer SUCCESS in 4m 25s

@mariolenz mariolenz closed this Jul 25, 2023
@mariolenz mariolenz reopened this Jul 25, 2023
@mariolenz mariolenz closed this Jul 25, 2023
@mariolenz mariolenz reopened this Jul 25, 2023
@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/ceba5c84a184421bb213ca1a19aa1ca3

✔️ ansible-tox-linters SUCCESS in 8m 52s
✔️ build-ansible-collection SUCCESS in 9m 58s
❌ ansible-test-cloud-integration-vcenter7_only-stable215 NODE_FAILURE Node request 200-0006228275 failed in 0s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 18m 26s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 50m 26s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 53m 22s
✔️ ansible-galaxy-importer SUCCESS in 6m 45s

@Alestor
Copy link
Contributor Author

Alestor commented Jul 25, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/0d0e1b41dd7e4032a658ebb013eafba2

✔️ ansible-tox-linters SUCCESS in 8m 47s
✔️ build-ansible-collection SUCCESS in 9m 47s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 19m 28s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 NODE_FAILURE Node request 200-0006228595 failed in 0s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 54m 11s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 52m 56s
✔️ ansible-galaxy-importer SUCCESS in 3m 26s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/f5d855204d1249018d08e72edb1384aa

✔️ ansible-tox-linters SUCCESS in 8m 34s
✔️ build-ansible-collection SUCCESS in 9m 33s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 19m 40s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 17m 48s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 RETRY_LIMIT in 1h 07m 02s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 57m 33s
✔️ ansible-galaxy-importer SUCCESS in 4m 22s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/63cd587acbed476a92f42ffd777b7a64

✔️ ansible-tox-linters SUCCESS in 8m 49s
✔️ build-ansible-collection SUCCESS in 9m 33s
❌ ansible-test-cloud-integration-vcenter7_only-stable215 NODE_FAILURE Node request 200-0006230436 failed in 0s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 16m 44s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 NODE_FAILURE Node request 200-0006230094 failed in 0s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 NODE_FAILURE Node request 200-0006230095 failed in 0s
✔️ ansible-galaxy-importer SUCCESS in 4m 43s

@mariolenz
Copy link
Collaborator

recheck

@mariolenz mariolenz closed this Jul 26, 2023
@mariolenz mariolenz reopened this Jul 26, 2023
@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/14022dd328b04233b074643985055dae

✔️ ansible-tox-linters SUCCESS in 8m 35s
✔️ build-ansible-collection SUCCESS in 9m 27s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 18m 42s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 NODE_FAILURE Node request 200-0006230944 failed in 0s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 NODE_FAILURE Node request 200-0006231286 failed in 0s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 52m 49s
✔️ ansible-galaxy-importer SUCCESS in 4m 41s

@mariolenz
Copy link
Collaborator

recheck

@mariolenz mariolenz mentioned this pull request Jul 26, 2023
Closed
@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/ddbc59f8594c483b9d8a484ec5aeb241

✔️ ansible-tox-linters SUCCESS in 8m 43s
✔️ build-ansible-collection SUCCESS in 9m 45s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 FAILURE in 19m 31s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 02s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b37e9de46b8f4c57b2e20fcc892e9073

✔️ ansible-tox-linters SUCCESS in 8m 46s
✔️ build-ansible-collection SUCCESS in 9m 32s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 19m 35s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 16m 49s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 52m 43s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 54m 29s
✔️ ansible-galaxy-importer SUCCESS in 4m 28s

mariolenz
mariolenz approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Alestor, I think this is really a valuable new feature. And thanks for having so much patience with our CI 😩

@alinabuzachis @jillr FYI This time the CI succeeded 🎉

@mariolenz mariolenz added feature This issue/PR relates to a feature request has_issue mergeit labels Jul 26, 2023
@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/c37446fd16bc447cbd434934edd7b983

✔️ ansible-tox-linters SUCCESS in 8m 27s
✔️ build-ansible-collection SUCCESS in 7m 36s
✔️ ansible-galaxy-importer SUCCESS in 4m 10s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 69d0ce7 into ansible-collections:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariolenz mariolenz mariolenz approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request has_issue mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Add ability to set vm migrateencrypt attribute
2 participants
@Alestor @mariolenz