Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GHA matrix template #62

Merged
merged 6 commits into from
Jul 12, 2023

Conversation

Andersson007
Copy link
Contributor

SUMMARY

Update GHA matrix template.

Relates to ansible-community/community-topics#237

@Andersson007
Copy link
Contributor Author

cc @felixfontein @briantist
thanks @Spredzy for mentioning this yesterday

Co-authored-by: Felix Fontein <felix@fontein.de>
@briantist
Copy link
Contributor

I feel somewhat uncomfortable about asking (especially new) maintainers to try to limit their CI usage. I think the decision of what to test should be primarily based on what makes for good content and test coverage, and I worry this sends a message to folks that they should be spending more time and effort on cutting tests.

I do think it's a good idea to explain that limits on concurrency specifically are shared limits in the organization and to be mindful especially of long-running tests... but I do want to be careful about the wording.

I'm not sure if I'm overthinking the message.

(comment also applies to ansible/ansible-documentation#40)

@Andersson007
Copy link
Contributor Author

I feel somewhat uncomfortable about asking (especially new) maintainers to try to limit their CI usage. I think the decision of what to test should be primarily based on what makes for good content and test coverage, and I worry this sends a message to folks that they should be spending more time and effort on cutting tests.

I do think it's a good idea to explain that limits on concurrency specifically are shared limits in the organization and to be mindful especially of long-running tests... but I do want to be careful about the wording.

I'm not sure if I'm overthinking the message.

(comment also applies to ansible/ansible-documentation#40)

@briantist sounds fair, thanks! Changed the wording a bit. How about now?

Copy link
Contributor

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some ideas, don't know if they are helpful.

Andersson007 and others added 3 commits July 11, 2023 08:50
Co-authored-by: Mario Lenz <m@riolenz.de>
Co-authored-by: Mario Lenz <m@riolenz.de>
@Andersson007 Andersson007 merged commit 5f6a378 into ansible-collections:main Jul 12, 2023
@Andersson007
Copy link
Contributor Author

@felixfontein @briantist @mariolenz @russoz thanks a lot for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants