Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: limit ibc withdrawal of assets only for the same chain #1783

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

pedrorezende
Copy link
Collaborator

@pedrorezende pedrorezende commented Feb 27, 2025

The target chain on Withdrawal should always be the original chain of the selected asset.

Fixes #1747

Copy link
Collaborator

@euharrison euharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!


export const chainHasFeeTokenDenom = (chain: Chain, denom: string): boolean => {
return !!chain.fees?.fee_tokens?.some(
(feeToken) => feeToken.denom.toLowerCase() === denom.toLowerCase()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedrorezende pedrorezende merged commit 8a960b1 into main Feb 27, 2025
7 checks passed
@pedrorezende pedrorezende deleted the namadillo/limiting-withdrawal-same-chain branch February 27, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent users from 'withdrawing' from namada to non native asset source chains
2 participants