fix: register ledger device #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszjasiuk
requested review from
jurevans,
pedrorezende and
euharrison
and removed request for
jurevans and
pedrorezende
jurevans
reviewed
Feb 26, 2025
| @@ -4,14 +4,16 @@ import { twMerge } from "tailwind-merge"; | |||
|
|
|||
| type IconTooltipProps = { | |||
| icon: React.ReactNode; | |||
| text: string; | |||
| text: string | React.ReactNode; | |||
There was a problem hiding this comment.
I think this could just be React.ReactNode - I believe that type includes string, number, etc
jurevans
reviewed
Feb 26, 2025
| </p> | ||
| <p className="text-sm"> | ||
| The <b>Register Ledger Device</b> button remains active because we have | ||
| no way to check if a device is already registered. |
There was a problem hiding this comment.
I would maybe reword this:
The Register Ledger Device button remains active because we have
no way to check if a device is already registered.
It is normal to see the Register Ledger Device button after registering due to limitations of Ledger registration detection in browser.
...
Or something. Hmmm, I dunno, it just feels a little weird, but is likely fine! I get why it should be here
jurevans
approved these changes
Feb 26, 2025
mateuszjasiuk
force-pushed
the
feat/ledger-masp-integration-branch
branch
from
d2717e3 to
5174dd5
Compare
mateuszjasiuk
force-pushed
the
fix/register-ledger-device
branch
from
7270cb0 to
a87555f
Compare
mateuszjasiuk
merged commit d5ac94a
into
feat/ledger-masp-integration-branch
7 checks passed
jurevans
pushed a commit
that referenced
this pull request
Feb 27, 2025
* fix: register ledger device * feat: refactor + cleanup * fix: code review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one annoying thing that after going back from settings we have to choose asset once again, but we can improve it later.
register.device.mp4