Ledger MASP Integration #1575
Open
Ledger MASP Integration #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurevans
added
App: Namadillo
App: Extension
Ledger HW Wallet
mateuszjasiuk
force-pushed
the
feat/ledger-masp-integration-branch
branch
from
c02399f to
af9a137
Compare
mateuszjasiuk
force-pushed
the
feat/ledger-masp-integration-branch
branch
from
a7567d8 to
736e5fb
Compare
8 tasks
mateuszjasiuk
force-pushed
the
feat/ledger-masp-integration-branch
branch
from
736e5fb to
1b17ec9
Compare
jurevans
force-pushed
the
feat/ledger-masp-integration-branch
branch
2 times, most recently
from
44b5a2c to
d2717e3
Compare
jurevans
requested review from
mateuszjasiuk,
euharrison and
pedrorezende
and removed request for
mateuszjasiuk and
euharrison
mateuszjasiuk
force-pushed
the
feat/ledger-masp-integration-branch
branch
from
d2717e3 to
5174dd5
Compare
* feat: bump to latest Ledger package * feat: begin hooking up shielded keys import * feat: split proof-gen and viewing key calls, fix paths * fix: fix tests * feat: stealing Mateusz code, show payment address in confirmation * feat: validate semver of installed app for Zip32 * feat: begin implementing import approval steps
* feat: ledger shielded accounts * fix: prettier fmt
* feat: support ledger masp tx wip * feat: unshielding working * chore: cleanup * feat: ledger masp with disposable signer * feat: disposable signer for shielded transfers using ledger * feat: proper flow for ledger txs from masp source
…r device (#1572) * feat: disable submit button for masp tx using disconnected ledger * fix: do not check for conencted ledger while tx is submitting
* feat: check Ledger app version before enabling zip32 * feat: store correct zip32 path * feat: support old version of Ledger (transparent account)
* fix: register ledger device * feat: refactor + cleanup * fix: code review comments
jurevans
force-pushed
the
feat/ledger-masp-integration-branch
branch
from
d5ac94a to
ce14984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines all work on Ledger MASP integration into a single branch ahead of actually merging to
mainand releasing keychain. We can do a final review, merge, and release. With #1699 we don't have to wait for Ledger app to be released to Ledger Live to merge this, as we are now performing the necessary checks to avoid any issues.Original PRs:
Closes #1698