Update build-release.yml #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add back in the mac arm build
| @@ -26,6 +26,8 @@ jobs: | |||
| include: | |||
| - os: macos-12 | |||
| platform: 'darwin-x64' | |||
| - os: macos-12 | |||
There was a problem hiding this comment.
I think you'll probably need to add this platform back into the list here:
Line 104 in 883eb62
There was a problem hiding this comment.
Oh wait, that's just the linux ones, so never mind...
warren-animoto
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Makes sense. We'll have to make a new release in this repo so that mediamoto can pull it down by release/tag name (currently 8.15.2).
We should probably do some mediamoto testing (with HEIC and other files) before we push up the updated install_custom_libvips.sh file in that repo because we'll be grabbing this new sharp version in production as well as locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds back in the mac arm build. @warren-animoto I'm hoping this will be as simple as this, I just re-instated this value that you removed a couple of commits ago.