Fix/async compile warnings #168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forge36
force-pushed
the
fix/async-compile-warnings
branch
from
95c2fbb to
a73b1db
Compare
|
Branch has errors now flagged with WIP commit error:
|
|
Removed fixes which caused fatal errors and fixed typo in the require This leaves the following warnings: |
Forge36
force-pushed
the
fix/async-compile-warnings
branch
3 times, most recently
from
cc5eeb3 to
fa3c709
Compare
This includes parameter definitions to ensure functions are called with correct number of parameters and byte-compile can produce warnings for bad callers.
I'm unable unfamiliar with the constructor syntax. These won't currently validate the number of passed parameters is accurate.
This resolves a byte-compiler warning defalias within a statement appears to confuse the compiler[1] [1]: https://emacs.stackexchange.com/questions/29853/defun-inside-let-with-lexical-binding-gives-byte-compile-warning-the-function-i?rq=1
Forge36
force-pushed
the
fix/async-compile-warnings
branch
from
fa3c709 to
e9df24c
Compare
|
This declares functions with parameters when I can determine them. Given my unfamiliarity with constructors I've declared the function without parameter validation. |
|
Thanks a lot for the problem description and the MR! I've managed to reproduce the problems and merged a PR partly based on your suggested changes (#169). Could you check whether it has fixed the problems you were encountering? |
|
Issue fixed upstream! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165