(ament_cpplint) Update cpplint version to v2.0.0 #522
Conversation
EricVoll
changed the title
There was a problem hiding this comment.
Thanks for the PR. Our policy is to use the version available from system packages on Ubuntu. This way the version is consistent across all target platforms. Ubuntu 24.04 Noble (the Ubuntu version targeted for Rolling and Jazzy) currently provides version 1.6.1, so we could bump to that: https://packages.ubuntu.com/noble/cpplint.
(The current version is 1.5.5 because that was the version provided by Ubuntu 22.04 Jammy, and it just hasn't been bumped yet: https://packages.ubuntu.com/jammy/cpplint)
Also, please sign off your commit, see: https://docs.ros.org/en/rolling/The-ROS2-Project/Contributing/Developer-Guide.html#change-control-process.
I wonder if we should re-apply the changes that we made on top: https://github.com/ament/ament_lint/commits/185613c26a3f65cc802dc5bc05d42fd36381040f/ament_cpplint/ament_cpplint/cpplint.py |
PR #501 already contained an update to the latest
cpplintversion at the time. It was decided to split the changes there into two PRs. This PR updates the cpplint version tov2.0.0, which is superseded by 5 PRs fixing various things.I went with v2.0.0. to have an officially released version instead of some mid-release version.
Fixes #500