pin "rack" gem to v2.2 #1277
Closed
pin "rack" gem to v2.2 #1277
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous config allowed rack to be bumped to a higher version (e.g. 3) which introduced errors when running the test [1] for CI and for new users running locally. This sets the version to no greater than 2.2 as a temporary fix to allow tests to pass, until updates can be made to fix the breaking changes. [1] https://gds.slack.com/archives/C03D792LYJG/p1718295709926239?thread_ts=1718203657.261269&cid=C03D792LYJG
|
I've raised an issue on the related gem here (tried to fix it, but it wasn't as easy as I imagined) pact-foundation/pact-mock_service#151 |
pezholio
approved these changes
Jun 14, 2024
|
a fix for the pact upstream error has been merged into pact-mock_service here, so once the library is updated this PR shouldn't be necessary https://github.com/pact-foundation/pact-mock_service/releases/tag/v3.12.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous config allowed rack to be bumped to a higher version (e.g. 3) which introduced errors when running the tests [1] for CI (#1276) and for new users running locally.
This sets the version to no greater than 2.2 as a temporary fix to allow tests to pass, until updates can be made to fix the breaking changes.
[1] https://gds.slack.com/archives/C03D792LYJG/p1718295709926239?thread_ts=1718203657.261269&cid=C03D792LYJG
more context
It looks like the error is thrown by pact_mock-service, which should have introduced compatibility with rack 3+ here pact-foundation/pact-mock_service#146
Stu has raised an issue here pact-foundation/pact-mock_service#151