implement new version of remove_parameter_value_pair #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use simple python types as arguments - allows to use white cards for all parameters, value-names and/or value-version - easier internal implementation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
+ Coverage 94.91% 95.30% +0.38%
==========================================
Files 10 10
Lines 374 405 +31
Branches 98 113 +15
==========================================
+ Hits 355 386 +31
Misses 8 8
Partials 11 11 ☔ View full report in Codecov by Sentry. |
- The refactoring of remove_parameter_value_pair() is driven by the usage in the function get_expected_bashi_parameter_value_pairs(). Therefore the function was overworked to test the refactoring. - Moved get_expected_bashi_parameter_value_pairs() to the new module `results`. - Add many tests for get_expected_bashi_parameter_value_pairs() - CLANG_CUDA is now part of VERSIONS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals of the refactoring
Additional
Refactored
get_expected_bashi_parameter_value_pairs()because it uses heavilyremove_parameter_value_pair()is the reason for the refactoring.