Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: In-notebook install command no longer triggered if alpaca already importable #550

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

aarjaneiro
Copy link
Member

Fixes #549 by calling the pip install command only when importing fails.

@aarjaneiro aarjaneiro requested a review from hiohiohio as a code owner January 16, 2025 15:35
@aarjaneiro aarjaneiro changed the title fix: In-notebook install command not triggered if alpaca already importable fix: In-notebook install command no longer triggered if alpaca already importable Jan 16, 2025
Copy link
Contributor

@hiohiohio hiohiohio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hiohiohio hiohiohio merged commit 88221cb into master Jan 16, 2025
12 checks passed
@hiohiohio hiohiohio deleted the fix-nb-install-local-dev branch January 16, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Running notebooks will install alpaca-py from pip, potentially conflicting with local environment
2 participants