Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add payment method position to the gather cms data and fix typeError for display in page #326

Conversation

joyet-simon
Copy link
Contributor

Reason for change

Linear task

Code changes

We add the payment_method_position in the CmsFeatures Object and add a new proxy for WC_PAYMENT_GATEWAYS

How to test

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@joyet-simon joyet-simon requested a review from a team as a code owner February 14, 2025 15:05

This comment has been minimized.

This comment has been minimized.

@joyet-simon joyet-simon changed the title fix: add payment method position to the gather cms data Add payment method position to the gather cms data Feb 14, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@joyet-simon joyet-simon changed the title Add payment method position to the gather cms data Add payment method position to the gather cms data and fix typeError for display in page Feb 17, 2025

This comment has been minimized.

Copy link
Collaborator

@Francois-Gomis Francois-Gomis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test for private method get payment position

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 50%)

See analysis details on SonarQube Cloud

Copy link

❌ E2E tests have failed.
➡️ You can find the results here.

@joyet-simon joyet-simon merged commit 8ed8da1 into develop Feb 18, 2025
6 of 8 checks passed
@joyet-simon joyet-simon deleted the feature/ecom-2482-wc-add-payment_method_position-information-in-cms-feature branch February 18, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants