-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v1/me/business event endpoint #158
Merged
Francois-Gomis
merged 5 commits into
develop
from
feature/ecom-2370-php-client-add-v1mebusiness-event-endpoint
Jan 24, 2025
Merged
Add v1/me/business event endpoint #158
Francois-Gomis
merged 5 commits into
develop
from
feature/ecom-2370-php-client-add-v1mebusiness-event-endpoint
Jan 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyet-simon
reviewed
Jan 20, 2025
joyet-simon
reviewed
Jan 20, 2025
joyet-simon
reviewed
Jan 20, 2025
joyet-simon
approved these changes
Jan 20, 2025
webaaz
requested changes
Jan 21, 2025
src/Entities/DTO/MerchantBusinessEvent/AbstractBusinessEvent.php
Outdated
Show resolved
Hide resolved
src/Entities/DTO/MerchantBusinessEvent/CartInitiatedBusinessEvent.php
Outdated
Show resolved
Hide resolved
tests/Unit/Entities/DTO/MerchantBusinessEvent/CartInitiatedBusinessEventTest.php
Outdated
Show resolved
Hide resolved
tests/Unit/Entities/DTO/MerchantBusinessEvent/OrderConfirmedBusinessEventTest.php
Outdated
Show resolved
Hide resolved
Benjamin-Freoua-Alma
approved these changes
Jan 21, 2025
webaaz
approved these changes
Jan 21, 2025
Benjamin-Freoua-Alma
requested changes
Jan 24, 2025
tests/Unit/Entities/DTO/MerchantBusinessEvent/CartInitiatedBusinessEventTest.php
Show resolved
Hide resolved
|
Benjamin-Freoua-Alma
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
Linear task
Add business Event endpoints for analytics
Code changes
Add new DTO models :
OrderConfirmedBusinessEvent & CartInitiatedBusinessEvent
Add private endpoint and public methods to send DTO
sendOrderConfirmedBusinessEvent & sendCartInitiatedBusinessEvent
How to test
As a reviewer, you are encouraged to test the PR locally.
Checklist for authors and reviewers
Non applicable