Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v1/me/business event endpoint #158

Conversation

Francois-Gomis
Copy link
Collaborator

Reason for change

Linear task
Add business Event endpoints for analytics

Code changes

Add new DTO models :
OrderConfirmedBusinessEvent & CartInitiatedBusinessEvent

Add private endpoint and public methods to send DTO
sendOrderConfirmedBusinessEvent & sendCartInitiatedBusinessEvent

How to test

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

Copy link

sonarqubecloud bot commented Jan 24, 2025

Quality Gate Passed Quality Gate passed

Issues
8 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Francois-Gomis Francois-Gomis merged commit 3cb562d into develop Jan 24, 2025
13 checks passed
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma deleted the feature/ecom-2370-php-client-add-v1mebusiness-event-endpoint branch January 29, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants