Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in release-publish workflow #130

Merged

Conversation

carine-bonnafous
Copy link
Contributor

Reason for change

I forgot a closing double quote here : https://github.com/alma/alma-php-client/pull/118/files
(I copy/pasted the same code on the other repositories but happily I only made the mistake on this one)

This made the workflow fail, see here: https://github.com/alma/alma-php-client/actions/runs/10143933279/job/28046366381

Copy link

@carine-bonnafous carine-bonnafous marked this pull request as ready for review July 29, 2024 14:13
@carine-bonnafous carine-bonnafous requested a review from a team as a code owner July 29, 2024 14:13
@carine-bonnafous carine-bonnafous merged commit 3659df4 into main Jul 29, 2024
10 of 13 checks passed
@carine-bonnafous carine-bonnafous deleted the devx/fix-missing-quote-in-release-publish-workflow branch July 29, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants