Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle request level TlsConfig #996

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Handle request level TlsConfig #996

merged 2 commits into from
Feb 17, 2025

Conversation

algesten
Copy link
Owner

@algesten algesten commented Feb 11, 2025 •
edited
Loading

Close #995

@tifv
Copy link

tifv commented Feb 12, 2025

One thing that pops to mind is that if Config now has some kind of undocumented hidden state, this may have hidden consequences. Like, what happens if a request-level Config is somehow leaked and inserted into a new Agent? It would be correct for Agent::new_with_config to check/rectify the config it is supplied with.

@algesten
Copy link
Owner Author

Good point!

I think I can move the flag to be beside the config.

Thanks!

@algesten algesten force-pushed the fix/req-level-tls branch 2 times, most recently from 21e3705 to 5dc0cc2 Compare February 17, 2025 18:21
@algesten algesten merged commit dbc34b5 into main Feb 17, 2025
55 checks passed
@algesten algesten deleted the fix/req-level-tls branch February 17, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

agent.configure_request().tls_config() is ineffective if this is not the first request of the agent
2 participants
@algesten @tifv