Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making sure we error correctly when an invalid uri is passed #990

Merged
merged 3 commits into from
Feb 8, 2025
Merged

Making sure we error correctly when an invalid uri is passed #990

merged 3 commits into from
Feb 8, 2025

Conversation

jaytaph
Copy link
Contributor

@jaytaph jaytaph commented Feb 8, 2025 •
edited
Loading

Fixes issue #989

When the URI is either empty or invalid, the unwrap() will fail so we will catch this and return a correct error result.

@jaytaph jaytaph mentioned this pull request Feb 8, 2025
Closed
algesten
algesten approved these changes Feb 8, 2025
View reviewed changes
Copy link
Owner

@algesten algesten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. This is a glaring error.

Thanks!

@algesten
Copy link
Owner

algesten commented Feb 8, 2025

Just a quick cargo fmt to solve that.

@algesten algesten merged commit b64471b into algesten:main Feb 8, 2025
34 checks passed
@algesten algesten mentioned this pull request Feb 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algesten algesten algesten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaytaph @algesten