-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable control by default #219
base: master
Are you sure you want to change the base?
Conversation
If control is not enabled, many arguments don't work, including setting the presets necessary to allow PPG signal transmission, for example. I see no problem with enabling control always.
Hello, Thanks for the commit. with your change, streaming stops after about 5 secs after it starts in MacOS, default preset. |
Yes, I recommend changing to preset 61, which will work for most people immediately. It would not support the aux electrodes, but I think including them by default for most people is confusing. I rewrote the preset function actually and could share that code as well. I can't recall if the base code actually works for setting presets. |
@blue-j |
I've attached documentation about the presets, in case 61 is not desirable as default: and here is my fork of the preset function, if it works for you, i would be happy to contribute it.
|
@blue-j Thanks so much! It clearly resolved my questions. I will try with actual device then update : ) |
Thank you for sharing the details about the presets. I have passed the past hour trying to understand why the PPG stream was not working and now I finally I have found the magic 61 preset thanks to you :) |
If control is not enabled, many arguments don't work, including setting the presets necessary to allow PPG signal transmission, for example. I see no problem with enabling control always.