Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving GA to setup-uv instead of setup-python #267

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Moving GA to setup-uv instead of setup-python #267

merged 1 commit into from
Dec 9, 2024

Conversation

alcides
Copy link
Owner

@alcides alcides commented Dec 9, 2024

No description provided.

@GUIpsp
Copy link
Collaborator

GUIpsp commented Dec 9, 2024

Another nit you might want to fix before merging - the versions on the pyproject.toml are over-constrained. You might want to relax them a bit (for most cases switching == to ~= should be OK) so that installing doesn't generate conflicts with other packages.

If you also want to do uv-based project management (https://docs.astral.sh/uv/guides/projects/), you can also fully drop the requirements.txt, and the requirements-dev.txt (after doing uv add --dev -r requirements-dev.txt). This means that dependencies are then only listed in one place.

Copy link

codspeed-hq bot commented Dec 9, 2024

CodSpeed Performance Report

Merging #267 will degrade performances by 38.5%

Comparing setup_uv (8f5bd25) with main (9acb343)

Summary

❌ 1 regressions
✅ 20 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main setup_uv Change
test_bench_crossover[StackGP] 53.1 s 86.3 s -38.5%

@alcides alcides force-pushed the setup_uv branch 3 times, most recently from d138413 to bee31e5 Compare December 9, 2024 16:12
Removed system from uv pip

Installing Python is not explicit

Added glob cache

Add flake8 to dev requirements

Removed pyflake

not installing to system

Removed frozen

Fixed syntax

Moved benchmarking and publish to setup-uv

Changed publish GA action

Added lockfile

Moved all actions to 3.13

Went back to python version via uv

Uniformed GA
@alcides alcides merged commit 6a8997f into main Dec 9, 2024
16 checks passed
@alcides alcides deleted the setup_uv branch December 9, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants