-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domino fit example #225
Domino fit example #225
Conversation
@Su2001 This is not passing the Ruff test. My guess is that you have not installed the pre-commit on your machine. Furthermore, can you include the Domino example in the run_examples script? |
Passed pre-commit and added in run_example |
Code review: If you want to have different strategies to solve the problem, you should have each in a different file, as different benchmarks. Regarding the fitness functions, they are too complex. Try to assess the following:
|
Some things seem to not be properly formatted still, you should run pre-commit run --all, or ruff fmt |
I have run pre-commit run --all, but it found an the error in this file tests/representations/basic_representation_test.py and no more fails are found |
Closes #163.