no-accessor-recursion: avoid crash on abstract accessor

ajafff · Nov 29, 2017 · 99ee15e · 99ee15e
1 parent d176055
commit 99ee15e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/rules/noAccessorRecursionRule.ts b/rules/noAccessorRecursionRule.ts
@@ -14,7 +14,7 @@ function walk(ctx: Lint.WalkContext<void>) {
     let name: string | undefined;
 
     return ctx.sourceFile.statements.forEach(function cb(node: ts.Node): any {
-        if (isAccessorDeclaration(node)) {
+        if (isAccessorDeclaration(node) && node.body !== undefined) {
             const before = name;
             name = getPropertyName(node.name);
             node.body.statements.forEach(cb);

diff --git a/test/rules/no-accessor-recursion/default/test.ts.lint b/test/rules/no-accessor-recursion/default/test.ts.lint
@@ -82,4 +82,13 @@ obj = {
     }
 }
 
+abstract class MyClass {
+    abstract get prop(): string;
+
+    set prop(v: string) {
+        this.prop = v;
+        ~~~~~~~~~ [fail]
+    }
+}
+
 [fail]: accessor recursion is not allowed