Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this puts us in a situation where releasing incremental small changes is going to require much more special care than we should have.
WE MUST do it the same every time leaning on
cargo release
and allowing things to be uploaded to crates. We should not sacrifice this status quo for minor aesthetics. The bench feature is probably not wildly used at the moment anyways.We also do not know when the upstream changes are going to be merged for textplot and I refuse to be in this broken release state for a long period of time. Any admin should be able to blindly run
cargo release
with no hand holding.I have commented out the
.borders
call for now and left a todo comment reminding us to reintroduce the call once the pull request is merged and the crate is updated on crates.io