Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove textplot fork for now #1102

Merged
merged 1 commit into from
Feb 18, 2025
Merged

remove textplot fork for now #1102

merged 1 commit into from
Feb 18, 2025

Conversation

rvcas
Copy link
Member

@rvcas rvcas commented Feb 18, 2025

this puts us in a situation where releasing incremental small changes is going to require much more special care than we should have.

WE MUST do it the same every time leaning on cargo release and allowing things to be uploaded to crates. We should not sacrifice this status quo for minor aesthetics. The bench feature is probably not wildly used at the moment anyways.

We also do not know when the upstream changes are going to be merged for textplot and I refuse to be in this broken release state for a long period of time. Any admin should be able to blindly run cargo release with no hand holding.

I have commented out the .borders call for now and left a todo comment reminding us to reintroduce the call once the pull request is merged and the crate is updated on crates.io

@rvcas rvcas requested a review from a team as a code owner February 18, 2025 19:50
@Quantumplation
Copy link
Contributor

Looks good to me; Do you have a screenshot of what difference it makes on the CLI?

@Quantumplation
Copy link
Contributor

(also, a link to the PR we're dependent on, as a convenience for anyone stumbling on this PR in the future: loony-bean/textplots-rs#57)

@rvcas
Copy link
Member Author

rvcas commented Feb 18, 2025

@Quantumplation I have no idea how to use the new bench keyword lmao

it's kind of like the fuzzer stuff though

@rvcas
Copy link
Member Author

rvcas commented Feb 18, 2025

@Quantumplation it looks perfectly fine actually
CleanShot 2025-02-18 at 15 00 25@2x

which supports my idea that screwing the typical release flow is not worth it just for borders, we can bring them back later :)

don't get me wrong, I do think it's better WITH borders but not at the expense of an awkward and untypical release flow.

things must go to crates always.

@rvcas rvcas merged commit 7472428 into main Feb 18, 2025
13 checks passed
@rvcas rvcas deleted the remove_fork branch February 18, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ In Next Release
Development

Successfully merging this pull request may close these issues.

3 participants