Fix various bugs with the type generation of the deriving mechanism #14
+136
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhatisRT
force-pushed
the
fix-deriving-type-generation
branch
3 times, most recently
from
208fcef to
c38d58f
Compare
N-ary types were omitted and some DB indices were a bit off in some scenarios.
WhatisRT
force-pushed
the
fix-deriving-type-generation
branch
from
c38d58f to
11ad0f5
Compare
omelkonian
reviewed
Feb 28, 2025
Comment on lines
+147
to
+150
| hasUnsolvedMetas : Term → M Bool | ||
| hasUnsolvedMetas' : List (Arg Term) → M Bool | ||
| hasUnsolvedMetasCl : List Clause → M Bool | ||
| hasUnsolvedMetasTel : Telescope → M Bool |
There was a problem hiding this comment.
There is some duplication with Reflection.Utils.TCI.ensureNoMetas but I could not find an easy way to replace the use in declareAndDefineFunsDebug, so keeping it for now is OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N-ary types were omitted and some DB indices were a bit off in some scenarios. Closes #13.