-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes 2814, 2815 #2816
base: master
Are you sure you want to change the base?
Fixes 2814, 2815 #2816
Conversation
Just updated this PR as it was still stripping the Note for testers - You'll need to update the
|
@@ -107,6 +107,7 @@ define([ | |||
htmlSupport: { | |||
// Convert all allow/disallow strings to regexp, as config is json only | |||
allow: convertStringsToRegExDeep((Origin.constants.ckEditorHtmlSupport && Origin.constants.ckEditorHtmlSupport.allow) || []), | |||
allowEmpty: ['span', 'i'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @simondate, I'm curious as to why we're allowing the tag here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean? Do you think we should also expose options here in config/config.json
?
I guess that will make this release slightly more future proof? As if in the future more attributes are added we can extend it further there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, that was supposed to say, <i>
tag, rather than making the rest of the line italicised!
So was just asking why HTML italic tag is there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was just in the example that I copied from CKEditior's website. I know that some other icon packs such as Font Awesome use <i>
, so perhaps someone else may find it useful.
Just discovered that the any links to Glossary objects also weren't working. The latest commit fixes this too. |
Fixes -
Two issues with CKEditor.