Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 2814, 2815 #2816

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fixes 2814, 2815 #2816

wants to merge 5 commits into from

Conversation

simondate
Copy link
Member

@StuartNicholls StuartNicholls self-requested a review February 12, 2025 14:47
@simondate
Copy link
Member Author

simondate commented Feb 12, 2025

Just updated this PR as it was still stripping the aria-hidden="true" attribute.

Note for testers - You'll need to update the conf/config.json file, to include this -

 "ckEditorHtmlSupport": {
    "allow": [
      {
        "name": "^(blockquote|ul|ol|span)$",
        "attributes": true,
        "classes": true,
        "styles": true
      },
      {
        "name": ".*",
        "classes": true,
        "styles": true
      },
      {
        "name": "^a$",
        "attributes": {
          "target": true
        }
      }
    ],
    "allowEmpty": [
      "span", 
      "i"
    ]
  },

@@ -107,6 +107,7 @@ define([
htmlSupport: {
// Convert all allow/disallow strings to regexp, as config is json only
allow: convertStringsToRegExDeep((Origin.constants.ckEditorHtmlSupport && Origin.constants.ckEditorHtmlSupport.allow) || []),
allowEmpty: ['span', 'i'],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @simondate, I'm curious as to why we're allowing the tag here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean? Do you think we should also expose options here in config/config.json?

I guess that will make this release slightly more future proof? As if in the future more attributes are added we can extend it further there.

Copy link

@StuartNicholls StuartNicholls Feb 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, that was supposed to say, <i> tag, rather than making the rest of the line italicised!

So was just asking why HTML italic tag is there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just in the example that I copied from CKEditior's website. I know that some other icon packs such as Font Awesome use <i>, so perhaps someone else may find it useful.

@simondate
Copy link
Member Author

Just discovered that the any links to Glossary objects also weren't working.

The latest commit fixes this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants