WIP: Modernize layer to use new primitives #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is blocked on juju/charm-tools#252 |
|
|
||
| def __call__(self): | ||
| raise Exception('dependencies.txt is deprecated see ' | ||
| 'https://github.com/battlemidget/juju-layer-ruby/pull/8') |
There was a problem hiding this comment.
It'll be even cooler when it works
|
but it does bad things! -> http://paste.ubuntu.com/23112942/ see #9 |
|
@jamesbeedy still a WIP, I reverted the previous PR so you should be ok |
|
@jamesbeedy yeah, you're hitting juju/charm-tools#252 |
|
whats the status on this? |
|
I'm going to remerge this and work to fix any issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is much like adam-stokes/juju-layer-nginx#6 but pushes even further on the idea. I made sure
rubylibis available for backwards compat, but ultimately this will make things work as most others do today.The last thing I want to do is build a custom tactic that helps warn/error for those using dependency.txt in their charm so that people can update without problem