Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some errors will never appear... #5

Open
dl9sec opened this issue Dec 5, 2017 · 1 comment
Open

Some errors will never appear... #5

dl9sec opened this issue Dec 5, 2017 · 1 comment

Comments

@dl9sec
Copy link

dl9sec commented Dec 5, 2017

Hi,

as far as i see, the errors

MAX31865_FAULT_REFINLOW
MAX31865_FAULT_REFINHIGH
MAX31865_FAULT_RTDINLOW

will never appear.
These are the bits 3 to 5 in the fault register, which are only handled, if a fault-detection cycle is initiated through the config register. Neither readFault() nor any other method seems to trigger a fault-detection cycle.
Could be a great improvement to do this alway in readFault() or to overload the method and give a parameter to trigger automatic or manual fault-detection mode.
Currently an unconnected sensor could not be detected through readFault(), but this is implied trough the example.

Edit:
I supplied two patches for the .cpp and .h files with an extended readFault() method. Just call readFault(true) to initiate a fault-detection cycle. readFault(false) gives the same result as readFault().
To be improved... :-)

Regards, Thorsten

Adafruit_MAX31865.cpp.patch.txt
Adafruit_MAX31865.h.patch.txt

@xmenxwk
Copy link

xmenxwk commented Mar 19, 2018

You should have added a pull request.

AnHardt added a commit to AnHardt/Adafruit_MAX31865 that referenced this issue Mar 12, 2020
Using code from adafruit#5
AnHardt added a commit to AnHardt/Adafruit_MAX31865 that referenced this issue Mar 12, 2020
Using code from adafruit#5
AnHardt added a commit to AnHardt/Adafruit_MAX31865 that referenced this issue Mar 12, 2020
Using code from adafruit#5
AnHardt added a commit to AnHardt/Adafruit_MAX31865 that referenced this issue Mar 13, 2020
Add the possibility to do a 'automatic fault-detection cycle' and use it during begin().

Using code from and fixing adafruit#5
AnHardt added a commit to AnHardt/Adafruit_MAX31865 that referenced this issue Sep 14, 2020
Add the possibility to do a 'automatic fault-detection cycle' and use it during begin().

Using code from and fixing adafruit#5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants