This repository was archived by the owner on Feb 10, 2025. It is now read-only.
Add gocardless support for Sparkasse Karlsruhe (Germany) #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a gocardless formatter, to properly format transaction information. Previously, additional remittance information was not supplied at all, and some creditor names were not set. This made recognizing transactions hard for users. Now, we pick out the best remittanceInformation that we find, and use a helpful order of possible data from the transaction as the creditorName. Fixes actualbudget#331
Nebukadneza
force-pushed
the
gocardless_add_sparkasse_karlsruhe
branch
from
636d76d to
cff89c0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a gocardless formatter, to properly format transaction information. Previously, additional remittance information was not supplied at all, and some creditor names were not set. This made recognizing transactions hard for users.
Now, we pick out the best remittanceInformation that we find, and use a helpful order of possible data from the transaction as the creditorName.
Fixes #331