This repository was archived by the owner on Feb 10, 2025. It is now read-only.
Make /admin/login return a descriptive error when no password is provided #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatissJanis
suggested changes
Apr 19, 2024
MatissJanis
approved these changes
Apr 19, 2024
trafico-bot
bot
added
✅ Approved
trafico-bot
bot
added
✨ Merged
joewashear007
pushed a commit
to joewashear007/actual-server
that referenced
this pull request
Apr 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308
This change makes
/account/loginconsistent with other non-authenticated endpoints and adds a more descriptive error message when no password is provided in the request body.Before
% curl -X POST http://localhost:5006/account/login {"status":"error","reason":"internal-error"}After
% curl -X POST http://localhost:5006/account/login {"status":"error","reason":"invalid-password"}