This repository was archived by the owner on Feb 10, 2025. It is now read-only.
Pending Transaction Support for SimpleFIN Integration #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for pending transactions (for banks that support them) from SimpleFIN.
|
Am I understanding this right? You are setting the booked field to each transaction to then leverage the existing logic on the client side to handle the pending? |
|
That is correct. I didn't think I should re-invent the wheel, since we had that logic there. I've done a full round of tests, to make sure it handles as expected: Imports pending SimpleFIN transactions as pending (uncleared), then later once it is no longer pending, it clears in Actual. |
youngcw
approved these changes
Feb 21, 2024
trafico-bot
bot
added
✅ Approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds pending transaction support for SimpleFIN (for the accounts that support pending transactions).
It follows the lead of the GoCardless integration, by importing pending transactions initially as uncleared, and then clearing when the transactions post.